Skip to content

Issues: code-423n4/2024-03-pooltogether-findings

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

45 Open 312 Closed
45 Open 312 Closed
Author
Filter by author
Label
Filter by label
Use alt + click/return to exclude labels
or ⇧ + click/return for logical OR
Projects
Filter by project
Milestones
Filter by milestone
Assignee
Filter by who’s assigned
Sort
Sort by
Newest Oldest Most commented Least commented Recently updated Least recently updated Best match
Most reactions
👍 👎 😄 🎉 😕 ❤️ 🚀 👀

Issues list

Gas Optimizations bug Something isn't working G (Gas Optimization) G-01 grade-b sufficient quality report This report is of sufficient quality
#352 opened Mar 11, 2024 by c4-bot-6
3
QA Report bug Something isn't working grade-b insufficient quality report This report is not of sufficient quality Q-01 QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax
#346 opened Mar 11, 2024 by c4-bot-6
6
The winner can steal claimer fees, and force him to pay for the gas 2 (Med Risk) Assets not at direct risk, but function/availability of the protocol could be impacted or leak value bug Something isn't working insufficient quality report This report is not of sufficient quality M-01 primary issue Highest quality submission among a set of duplicates 🤖_78_group AI based duplicate group recommendation satisfactory satisfies C4 submission criteria; eligible for awards selected for report This submission will be included/highlighted in the audit report sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity")
#345 opened Mar 11, 2024 by c4-bot-6
15
Analysis A-01 analysis-advanced grade-b sufficient quality report This report is of sufficient quality
#341 opened Mar 11, 2024 by c4-bot-10
2
_maxYieldVaultWithdraw() uses yieldVault.convertToAssets() 2 (Med Risk) Assets not at direct risk, but function/availability of the protocol could be impacted or leak value bug Something isn't working insufficient quality report This report is not of sufficient quality M-02 primary issue Highest quality submission among a set of duplicates 🤖_66_group AI based duplicate group recommendation satisfactory satisfies C4 submission criteria; eligible for awards selected for report This submission will be included/highlighted in the audit report sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity")
#336 opened Mar 11, 2024 by c4-bot-5
16
maxDeposit() uses yieldVault.maxDeposit() but _depositAndMint() uses yieldVault.mint() 2 (Med Risk) Assets not at direct risk, but function/availability of the protocol could be impacted or leak value bug Something isn't working insufficient quality report This report is not of sufficient quality M-03 primary issue Highest quality submission among a set of duplicates 🤖_66_group AI based duplicate group recommendation satisfactory satisfies C4 submission criteria; eligible for awards selected for report This submission will be included/highlighted in the audit report sponsor acknowledged Technically the issue is correct, but we're not going to resolve it for XYZ reasons
#335 opened Mar 11, 2024 by c4-bot-10
17
Dust sweeping may exceed yield vault deposit limit bug Something isn't working downgraded by judge Judge downgraded the risk level of this issue grade-a insufficient quality report This report is not of sufficient quality primary issue Highest quality submission among a set of duplicates Q-02 QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax 🤖_141_group AI based duplicate group recommendation satisfactory satisfies C4 submission criteria; eligible for awards
#333 opened Mar 11, 2024 by c4-bot-7
11
_withdraw() may attempt to withdraw more than available bug Something isn't working downgraded by judge Judge downgraded the risk level of this issue grade-a insufficient quality report This report is not of sufficient quality primary issue Highest quality submission among a set of duplicates QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax 🤖_90_group AI based duplicate group recommendation
#332 opened Mar 11, 2024 by c4-bot-7
11
Gas Optimizations bug Something isn't working G (Gas Optimization) G-02 grade-a sufficient quality report This report is of sufficient quality
#326 opened Mar 11, 2024 by c4-bot-7
6
Gas Optimizations bug Something isn't working G (Gas Optimization) G-03 grade-a sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity") sufficient quality report This report is of sufficient quality
#317 opened Mar 11, 2024 by c4-bot-7
6
Gas Optimizations bug Something isn't working G (Gas Optimization) G-04 grade-b sufficient quality report This report is of sufficient quality
#316 opened Mar 11, 2024 by c4-bot-2
3
Gas Optimizations bug Something isn't working G (Gas Optimization) G-05 grade-b sufficient quality report This report is of sufficient quality
#306 opened Mar 11, 2024 by c4-bot-9
3
Analysis A-02 analysis-advanced edited-by-warden grade-a high quality report This report is of especially high quality selected for report This submission will be included/highlighted in the audit report sponsor acknowledged Technically the issue is correct, but we're not going to resolve it for XYZ reasons
#305 opened Mar 11, 2024 by c4-bot-3
5
Gas Optimizations bug Something isn't working G (Gas Optimization) G-06 grade-b sufficient quality report This report is of sufficient quality
#303 opened Mar 11, 2024 by c4-bot-8
4
Analysis A-03 analysis-advanced grade-a high quality report This report is of especially high quality sponsor acknowledged Technically the issue is correct, but we're not going to resolve it for XYZ reasons
#299 opened Mar 11, 2024 by c4-bot-10
3
Analysis A-04 analysis-advanced grade-b sufficient quality report This report is of sufficient quality
#298 opened Mar 11, 2024 by c4-bot-7
3
Analysis A-05 analysis-advanced grade-b sufficient quality report This report is of sufficient quality
#289 opened Mar 11, 2024 by c4-bot-1
2
Analysis A-06 analysis-advanced grade-b sufficient quality report This report is of sufficient quality
#288 opened Mar 11, 2024 by c4-bot-8
2
Lack of Slippage Protection in withdraw/redeem Functions of the Vault 2 (Med Risk) Assets not at direct risk, but function/availability of the protocol could be impacted or leak value bug Something isn't working M-04 primary issue Highest quality submission among a set of duplicates 🤖_90_group AI based duplicate group recommendation satisfactory satisfies C4 submission criteria; eligible for awards selected for report This submission will be included/highlighted in the audit report sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity") sufficient quality report This report is of sufficient quality
#274 opened Mar 11, 2024 by c4-bot-6
13
Gas Optimizations bug Something isn't working G (Gas Optimization) G-07 grade-a sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity") sufficient quality report This report is of sufficient quality
#273 opened Mar 11, 2024 by c4-bot-7
6
QA Report bug Something isn't working grade-b insufficient quality report This report is not of sufficient quality Q-03 QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax
#250 opened Mar 11, 2024 by c4-bot-8
4
yieldFeeBalance wouldn't be claimed after calling transferTokensOut(). 2 (Med Risk) Assets not at direct risk, but function/availability of the protocol could be impacted or leak value bug Something isn't working insufficient quality report This report is not of sufficient quality M-05 🤖_188_group AI based duplicate group recommendation satisfactory satisfies C4 submission criteria; eligible for awards selected for report This submission will be included/highlighted in the audit report sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity")
#244 opened Mar 11, 2024 by c4-bot-9
10
QA Report bug Something isn't working grade-a high quality report This report is of especially high quality Q-04 QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity")
#237 opened Mar 11, 2024 by c4-bot-1
15
Gas Optimizations bug Something isn't working G (Gas Optimization) G-08 grade-a high quality report This report is of especially high quality selected for report This submission will be included/highlighted in the audit report sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity")
#236 opened Mar 11, 2024 by c4-bot-1
6
Funds locked due to missing transfer check 2 (Med Risk) Assets not at direct risk, but function/availability of the protocol could be impacted or leak value bug Something isn't working downgraded by judge Judge downgraded the risk level of this issue edited-by-warden high quality report This report is of especially high quality M-06 primary issue Highest quality submission among a set of duplicates 🤖_90_group AI based duplicate group recommendation satisfactory satisfies C4 submission criteria; eligible for awards selected for report This submission will be included/highlighted in the audit report sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity")
#235 opened Mar 11, 2024 by c4-bot-7
13
ProTip! Updated in the last three days: updated:>2024-05-27.