QA Report

[c4-bot-1]

See the markdown file with the details of this report here.

[raymondfam]

Generic findings well elaborated: 26 L and 58 NC

[c4-pre-sort]

raymondfam marked the issue as high quality report

[c4-sponsor]

trmid (sponsor) confirmed

[trmid]

[L-12] mitigation: GenerationSoftware/pt-v5-vault#86

[trmid]

[L-11] mitigation: GenerationSoftware/pt-v5-vault#87

[c4-judge]

hansfriese marked the issue as grade-a

[c4-judge]

hansfriese marked the issue as selected for report

[c4-judge]

hansfriese marked the issue as not selected for report

[hansfriese]

Invalid
[L-05] Code does not follow the best practice of check-effects-interaction

Known findings
[L-01] Centralization risk for privileged functions
The owner is a single point of failure and a centralization risk

[L-02] Subtraction in unchecked block is unsafe
unchecked blocks with subtractions may underflow

[L-04] Some tokens may revert on large transfers
ERC-20: Large transfers may revert

[L-06] Use abi.encodeCall() instead of abi.encodeWithSignature()/abi.encodeWithSelector()
Use abi.encodeCall() instead of abi.encodeWithSignature()/abi.encodeWithSelector()

[L-07] Upgradable contracts not taken into account
Consider making contracts Upgradeable

[L-10] Unchecked Return Values of the approve() Function
Return values of approve() not checked

[L-12] Unsafe use of transfer()/transferFrom() with IERC20
[L-13] Unchecked Return Values of transfer()/transferFrom()
ERC20: unsafe use of transfer()/transferFrom()

[L-15] Missing checks for address(0x0) when updating address state variables
Missing checks for address(0x0) when updating address state variables

[L-16] Lack of Parameter Validation in Constructor/Initializer]
Missing checks for address(0x0) in the constructor/initializer

...

Most findings are dupes of the known ones. I recommend filtering them when you submit with your bot results.

[c4-judge]

hansfriese marked the issue as grade-b

[c4-judge]

hansfriese marked the issue as grade-a

[trmid]

[N-37] mitigation: GenerationSoftware/pt-v5-vault#89

[trmid]

[N-22] mitigation: GenerationSoftware/pt-v5-vault#90

[trmid]

[N-20] mitigation: GenerationSoftware/pt-v5-vault#91

[trmid]

[N-15] mitigation: GenerationSoftware/pt-v5-vault#92