Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "go.mod: bump cloud.google.com/go/storage to v1.16.0" #68158

Merged
merged 4 commits into from Jul 28, 2021

Conversation

knz
Copy link
Contributor

@knz knz commented Jul 28, 2021

Reverts #67806

Informs #68154
Informs #65926

Fixes #68150
Fixes #68152
Fixes #68148
Fixes #68145
Fixes #68144
Fixes #68143

This reverts commit e52ddc8.

This is because that commit contains an upgrade to gRPC 1.39 which
contains a race condition.

Release note: None

This reverts commit e52ddc8.

This is because that commit contains an upgrade to gRPC 1.39 which
contains a race condition.

Release note: None
@knz knz requested a review from tbg July 28, 2021 08:28
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@knz knz mentioned this pull request Jul 28, 2021
6 tasks
@knz
Copy link
Contributor Author

knz commented Jul 28, 2021

thanks erik

bors r=erikgrinaker

@tbg
Copy link
Member

tbg commented Jul 28, 2021

cc @adityamaru

@craig
Copy link
Contributor

craig bot commented Jul 28, 2021

Build failed:

@knz
Copy link
Contributor Author

knz commented Jul 28, 2021

unrelated roachtest flake

bors r=tbg,erikgrinaker

@knz
Copy link
Contributor Author

knz commented Jul 28, 2021

the bors build is failing again. I'm going to try a 3rd time; if that fails again, I might need to append another commit to skip the flaky package and roachtest.

bors r-

@craig
Copy link
Contributor

craig bot commented Jul 28, 2021

Canceled.

@knz
Copy link
Contributor Author

knz commented Jul 28, 2021

bors r=tbg,erikgrinaker

@craig
Copy link
Contributor

craig bot commented Jul 28, 2021

Build failed:

Release note: None
@knz
Copy link
Contributor Author

knz commented Jul 28, 2021

Skipping cdc/bank #68167

@knz
Copy link
Contributor Author

knz commented Jul 28, 2021

skipping TestSinklessReplicationClient #68168

@knz knz requested a review from a team as a code owner July 28, 2021 11:22
@knz
Copy link
Contributor Author

knz commented Jul 28, 2021

bors r=tbg,erikgrinaker

@knz
Copy link
Contributor Author

knz commented Jul 28, 2021

now the linter is not happy 😭

bors r-

@craig
Copy link
Contributor

craig bot commented Jul 28, 2021

Canceled.

@knz
Copy link
Contributor Author

knz commented Jul 28, 2021

also, flake on #68107. I'll skip that one too

@knz
Copy link
Contributor Author

knz commented Jul 28, 2021

bors r=tbg,erikgrinaker

@craig
Copy link
Contributor

craig bot commented Jul 28, 2021

Build succeeded:

@craig craig bot merged commit dbbf8fb into cockroachdb:master Jul 28, 2021
@knz knz deleted the 20210728-grpc branch July 28, 2021 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants