go.mod: update goavro from 2.9 to 2.10 #67572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
6 tasks
HonoreDB
force-pushed
the
update_goavro
branch
8 times, most recently
from
b3b814b
to
5fbc446
Compare
stevendanna
force-pushed
the
update_goavro
branch
from
5fbc446
to
293d702
Compare
|
Overall this looks good. I ran |
|
(I have a local branch from before I pushed the tidy if any of this is problematic with work you have locally) |
2.10 provides support for large decimals and lets time of day values be provided as the underlying logical type, which is convenient because that's how we encode them. It also makes a breaking change if you were passing such values as duration types, which we were. Release note: None
stevendanna
force-pushed
the
update_goavro
branch
from
293d702
to
5d51d17
Compare
stevendanna
approved these changes
Jul 28, 2021
There was a problem hiding this comment.
Reviewable status:
complete! 1 of 0 LGTMs obtained (waiting on @HonoreDB)
a discussion (no related file):
|
bors r=[stevendanna] |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2.10 provides support for large decimals and lets time of day values
be provided as the underlying logical type, which is convenient
because that's how we encode them. It also makes a breaking change
if you were passing such values as duration types, which we were.
Release note: None