generate: remove additional handling of numeric values #702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In previous versions of our schema converter, we needed to handle the scenario
where a key inside of a map would contain a numeric value.
Note: This is only required for `TypeMap`s because it is the wild west and you
lose most of the validation with the Terraform internals when using maps.
```
resource "..." "..." {
foo = {
bar1 = "baz"
}
}
```
While numeric characters in attribute keys are permitted in HCL, they must be
quoted. Inadvertently, it looks like this was also being applied to the
attribute values. While a good measure, this isn't as important as we have
better measures to detect the value type and infer it appropriately.
This commit removes the additional handling and instead relies on the explicit
`.(type)` check instead which covers the key _and_ value.
|
@jafowler do you mind eyeballing this and confirm i'm not missing anything here post the rewrite we did to tidy up the nested fields? |
LGTM. I have faith our test suit would be angry otherwise :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In previous versions of our schema converter, we needed to handle the scenario
where a key inside of a map would contain a numeric value.
Note: This is only required for
TypeMaps because it is the wild west and youlose most of the validation with the Terraform internals when using maps.
While numeric characters in attribute keys are permitted in HCL, they must be
quoted. Inadvertently, it looks like this was also being applied to the
attribute values. While a good measure, this isn't as important as we have
better measures to detect the value type and infer it appropriately.
This commit removes the additional handling and instead relies on the explicit
.(type)check instead which covers the key and value.