Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

accounting for path where value is float64 #548

Closed

Conversation

jeff-onepeloton
Copy link

No description provided.

@jacobbednarz
Copy link
Member

@jeff-onepeloton thanks for the PR! for any maintainer to review this we're going to need more information.

  • overview of why this is needed and an example of where this is being encountered; and
  • a test case covering this new codepath (best done with an example resource).

without either of these we are flying blind and can't have confidence in the change does what it says it does.

@jeff-onepeloton
Copy link
Author

if you run generate on the cloudflare_load_balancer resource, it errors out on the pool_weights dictionary because the key in the dictionary passes the hasNumber() check but the value is a float64

panic: interface conversion: interface {} is float64, not string

Just wanted to bring this to attention since I spent some time investigating

@jacobbednarz
Copy link
Member

thanks for the context. if you can add a test case for this, i'm happy to review and get it merged.

@jacobbednarz
Copy link
Member

#702 solves this with updated test cases

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants