Get rid of some compile-time warnings. #712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoid static array size in SW sphere example. Update use of numpy C API in weno code.
|
Thanks to Lisandro Dalcin for contributing this patch, which removes several warnings that were being raised at compile time. |
ketch
added a commit
to ketch/clawpack
that referenced
this pull request
Nov 3, 2023
ketch
added a commit
to ketch/clawpack
that referenced
this pull request
Nov 3, 2023
rjleveque
added a commit
to rjleveque/clawpack
that referenced
this pull request
Nov 4, 2023
* v592: Some temporary modifications required until we merge clawpack/pyclaw#712. Update pyproject.toml with metadata and version number.
ketch
added a commit
to clawpack/clawpack
that referenced
this pull request
Nov 4, 2023
* v5.9.2 release candidate * Update pyproject.toml with metadata and version number. Preparation for release version 5.9.2. * Some temporary modifications required until we merge clawpack/pyclaw#712. --------- Co-authored-by: David Ketcheson <dketch@gmail.com>
|
Merging this PR seems useful and fairly urgent, since a lot of direct field access in |
|
Thanks for the reminder! I had forgotten about it... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid static array size in SW sphere example.
Update use of numpy C API in weno code.