Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NumPy 2.0 support #252

Open
rgommers opened this issue May 13, 2024 · 0 comments
Open

NumPy 2.0 support #252

rgommers opened this issue May 13, 2024 · 0 comments

Comments

@rgommers
Copy link
Contributor

NumPy 2.0 is coming out soon ( numpy/numpy#24300 ). NumPy 2.0.0rc1 packages for conda & wheels came out 6 weeks ago ( numpy/numpy#24300 (comment) ).

To prepare for NumPy 2.0, it might be worthwhile to start testing against NumPy 2 in CI

NumPy has put out a migration guide. More details are in the release notes

Clawpack does make use of NumPy's C API (via f2py) and produces one wheel per release (for macOS arm64, at https://pypi.org/project/Clawpack/5.10.0/#files), which will break. Therefore, having a release of XGBoost with wheels built against NumPy 2.0.0rc1 would be helpful to ensure that wheel is NumPy 1 & 2 compatibl (as wheels built against NumPy 1 won't be compatible with NumPy 2). More details in this NumPy 2 ABI doc

There are a number of C API usages in clawpack/pyclaw#712 that currently break the build against NumPy 2.0 RCs, so that PR should be merged. There may be other issues (I haven't checked).

Note that there is currently no cap on the numpy version in pyproject.toml:

"numpy",

That means that building from source with for example pip install clawpack will also break when NumPy 2.0 is released. Doing a new release with either numpy 2.0 support or at least a <2 version cap seems advisable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant