Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update failure tests README #5197

Merged
merged 3 commits into from Aug 26, 2021
Merged

Conversation

SaitTalhaNisanci
Copy link
Contributor

I keep finding this page when trying to run failure tests, so updating the README that way:
pypa/pipenv#3363 (comment)

I keep finding this page when trying to run failure tests, so updating the README that way:
pypa/pipenv#3363 (comment)
@hanefi
Copy link
Member

hanefi commented Aug 26, 2021

On my dev machine, your changes break the working list of documentation.

❯ pipenv --python 3.6
Creating a virtualenv for this project…
Using /home/hanefi/.pyenv/versions/3.6.12/bin/python3.6m (3.6.12) to create virtualenv…
⠋Running virtualenv with interpreter /home/hanefi/.pyenv/versions/3.6.12/bin/python3.6m
Using base prefix '/home/hanefi/.pyenv/versions/3.6.12'
New python executable in /home/hanefi/.local/share/virtualenvs/temp-fmDL7Ayc/bin/python3.6m
Also creating executable in /home/hanefi/.local/share/virtualenvs/temp-fmDL7Ayc/bin/python
Installing setuptools, pkg_resources, pip, wheel...done.

Virtualenv location: /home/hanefi/.local/share/virtualenvs/temp-fmDL7Ayc
Creating a Pipfile for this project…
❯ pipenv --python 3.6 --python=`which python3`
Virtualenv already exists!
Removing existing virtualenv…
Creating a virtualenv for this project…
Using /home/hanefi/.pyenv/shims/python3 (3.8.5) to create virtualenv…
⠋Running virtualenv with interpreter /home/hanefi/.pyenv/shims/python3
Using base prefix '/home/hanefi/.pyenv/versions/3.8.5'
/usr/lib/python3/dist-packages/virtualenv.py:1090: DeprecationWarning: the imp module is deprecated in favour of importlib; see the module's documentation for alternative uses
  import imp
New python executable in /home/hanefi/.local/share/virtualenvs/temp-fmDL7Ayc/bin/python3
Also creating executable in /home/hanefi/.local/share/virtualenvs/temp-fmDL7Ayc/bin/python
Installing setuptools, pkg_resources, pip, wheel...done.

Virtualenv location: /home/hanefi/.local/share/virtualenvs/temp-fmDL7Ayc
Warning: Your Pipfile requires python_version 3.6, but you are using 3.8.5 (/home/hanefi/.local/share/v/t/bin/python).
  $ pipenv check will surely fail.

@hanefi
Copy link
Member

hanefi commented Aug 26, 2021

For more context, I use pyenv to manage multiple python versions.

❯ pyenv versions
  system
  3.6.12
* 3.8.5 (set by /home/hanefi/.pyenv/version)

My Linux distro does not have packages for python3.6, so I started to use pyenv to handle that.

@codecov
Copy link

codecov bot commented Aug 26, 2021

Codecov Report

Merging #5197 (81aa1c5) into master (7e39c7e) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #5197      +/-   ##
==========================================
- Coverage   94.20%   94.20%   -0.01%     
==========================================
  Files         214      214              
  Lines       42121    42121              
==========================================
- Hits        39682    39681       -1     
- Misses       2439     2440       +1     

@SaitTalhaNisanci SaitTalhaNisanci merged commit d50830d into master Aug 26, 2021
@SaitTalhaNisanci SaitTalhaNisanci deleted the SaitTalhaNisanci-patch-2 branch August 26, 2021 09:35
SaitTalhaNisanci added a commit that referenced this pull request Sep 3, 2021
* Update failure tests README

I keep finding this page when trying to run failure tests, so updating the README that way:
pypa/pipenv#3363 (comment)

Co-authored-by: Hanefi Onaldi <Hanefi.Onaldi@microsoft.com>

Co-authored-by: Hanefi Onaldi <Hanefi.Onaldi@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants