Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rename M_HLVX to prevent clashing with M_FLUSH #3335

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

rename M_HLVX to prevent clashing with M_FLUSH #3335

wants to merge 1 commit into from

Conversation

Sh-Anand
Copy link

Type of change: bug report

Impact: no functional change

Development Phase: implementation

Release Notes

Renamed the constant M_HLVX from 10000 to 11000 to prevent clashing with M_FLUSH, as isRead would always return true for memory commands with M_FLUSH.

Note: The bug was spotted while working with boom/src/main/scala/lsu/dcache.scala of the BOOM. This prevents M_FLUSH commands from sending a response as s2_send_resp would always evaluate to false.

@linux-foundation-easycla
Copy link

CLA Not Signed

ZenithalHourlyRate
ZenithalHourlyRate approved these changes May 1, 2023
View reviewed changes
Copy link
Contributor

@ZenithalHourlyRate ZenithalHourlyRate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After inspecting M_HLVX related spec/code, it seems like a mistake instead of an intended clashing.

The order of the constants is also a hint.

Could you make this change against the dev branch? It will be backported to the master branch using mergify.

@jerryz123 jerryz123 changed the base branch from master to dev May 10, 2023 16:47
@jerryz123 jerryz123 changed the base branch from dev to master May 10, 2023 16:47
@jerryz123 jerryz123 changed the base branch from master to dev June 15, 2023 00:10
@jerryz123 jerryz123 changed the base branch from dev to master June 15, 2023 00:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZenithalHourlyRate ZenithalHourlyRate ZenithalHourlyRate approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Sh-Anand @ZenithalHourlyRate