Fix mdoc build failing (sbt) #3313
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I could remove the build.sbt changes and rebase this to dev? I'm just not sure how to build the Diplomacy docs with mill. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue:
Closes: #3230
Other related issues: #2960 #3312
Type of change: other enhancement
Impact: no functional change
Development Phase: implementation
Notes
()were necessary onmakeIOandmakeSinkbecause of Scala3 deprecation warnings. If the preference is no paraentheses, I believe this is something that can be addressed in [WIP] Porting Chisel 2 to Chisel 3: diplomacy #3289 or Fix Werror: empty argument list #3262 or a similar PR.