Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[C2] Delete some components that are not used #5385

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

[C2] Delete some components that are not used #5385

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1ac2f72
Internal: Remove old unused code
daniboygg Apr 17, 2024
f796817
Internal: Remove unused component
daniboygg Apr 17, 2024
ee2496d
Internal: Restore deleted elements
daniboygg Apr 24, 2024
0790826
Internal: Remove vuex from course creation
daniboygg Apr 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
42 changes: 0 additions & 42 deletions assets/vue/components/Snackbar.vue
View file
Open in desktop

This file was deleted.

76 changes: 0 additions & 76 deletions assets/vue/components/course/Filter.vue
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion assets/vue/mixins/NotificationMixin.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
import { mapFields } from 'vuex-map-fields';
import { useQuasar } from 'quasar';
import Snackbar from "../components/Snackbar.vue";

export default {
setup() {
Expand Down
10 changes: 4 additions & 6 deletions assets/vue/views/course/Create.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,7 @@
</template>

<script setup>
import { ref, computed } from 'vue'
import { useStore } from 'vuex'
import { ref } from 'vue'
import CourseForm from '../../components/course/Form.vue'
import Loading from '../../components/Loading.vue'
import { useRouter } from "vue-router"
Expand All @@ -31,18 +30,17 @@ import courseService from "../../services/courseService"
import { useI18n } from "vue-i18n"
import { useNotification } from "../../composables/notification"

const store = useStore()
const item = ref({})
const router = useRouter()
const { t } = useI18n()

const isLoading = computed(() => store.getters['course/getField']('isLoading'))
const violations = computed(() => store.getters['course/getField']('violations'))
const courseData = ref({})
const isLoading = ref(false)
const violations = ref(null)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The reference violations is used in the component CourseForm but this component has no property errors...

<CourseForm
      ref="createForm"
      :errors="violations"
      :values="item"
      @submit="submitCourse"
    />

const { showSuccessNotification, showErrorNotification } = useNotification()

const submitCourse = async (formData) => {
isLoading.value = true
violations.value = null
try {
const response = await courseService.createCourse(formData)
const courseId = response.courseId
Expand Down
12 changes: 0 additions & 12 deletions assets/vue/views/course/List.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,17 +14,6 @@
<!-- <h1>Course List</h1>-->
<!-- </v-flex>-->
<v-flex lg12>
<DataFilter
:handle-filter="onSendFilter"
:handle-reset="resetFilter"
>
<CourseFilterForm
ref="filterForm"
slot="filter"
:values="filters"
/>
</DataFilter>

<br />

<v-data-table
Expand Down Expand Up @@ -74,7 +63,6 @@ import { mapActions, mapGetters } from "vuex"
import { mapFields } from "vuex-map-fields"
import ListMixin from "../../mixins/ListMixin"
import ActionCell from "../../components/ActionCell.vue"
import CourseFilterForm from "../../components/course/Filter.vue"
import DataFilter from "../../components/DataFilter.vue"
import Toolbar from "../../components/Toolbar.vue"

Expand Down
2 changes: 1 addition & 1 deletion assets/vue/views/course/Update.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,4 +61,4 @@ export default {
}),
},
}
</script>
</script>