[C2] Delete some components that are not used #5385
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5385 +/- ##
============================================
- Coverage 40.77% 40.19% -0.59%
- Complexity 10214 10337 +123
============================================
Files 807 818 +11
Lines 42433 43470 +1037
============================================
+ Hits 17304 17473 +169
- Misses 25129 25997 +868 ☔ View full report in Codecov by Sentry. |
|
I'm not able to review this one, in particular because of the assets/vue/router/course.js removal. I think maybe the corresponding views are a work in progress to be used later. @AngelFQC if these are not works in progress, can we remove them and implement them correctly later on, or should we keep them there to hold the place for the file to be used later? |
|
To clarify my decision, I deleted the file course.js because there was no reference in the code to the routes created in /resources/courses/xxx. The components inside these routes were made with old libraries and didn't work at all. Because of the routes in https://github.com/chamilo/chamilo-lms/blob/master/assets/vue/router/index.js#L94 I may incorrectly guess that these were the correct ones ( |
assets/vue/router/course.js
Outdated
| { | ||
| name: 'CourseCreate', | ||
| path: 'new', | ||
| component: () => import('../views/course/Create.vue') | ||
| }, |
There was a problem hiding this comment.
CourseCreate is currently in use
assets/vue/views/course/Create.vue
Outdated
There was a problem hiding this comment.
This page is used to allow teachers to create their courses (from the orange button on the /courses page)
|
I reverted the changes. So, do we need the components CourseList, CourseUpdate and CourseShow. All of them are using vuex, but when I visit the route I see nothing. |
| const violations = computed(() => store.getters['course/getField']('violations')) | ||
| const courseData = ref({}) | ||
| const isLoading = ref(false) | ||
| const violations = ref(null) |
There was a problem hiding this comment.
The reference violations is used in the component CourseForm but this component has no property errors...
<CourseForm
ref="createForm"
:errors="violations"
:values="item"
@submit="submitCourse"
/>
|
An error occurred when fetching issues. View more on Code Climate. |
This will remove components that are not in use in Vue application. This will delete some unneeded vuex dependencies.
#5377