[DRAFT] feat(deps): update to node 18, yarn 4

[billhimmelsbach]

Found this bug when trying to run tests locally:

This bug is caused by running on an old version of node on older versions of yarn when using vitest, which has been fixed in later updates. Updating to the latest version of yarn fixes this issue (the DS did it earlier this year), but v4 of yarn also requires at least node 18. We should at least update from node 16 to node 18 anyway for the engine, since it's at EOL. We could also update all the way to node 20, or even 22 if we're ok with it not being a LTS release for a few months. We can probably wait till post-mvp for that change.

Changes

• update yarn to v4
• update node to 18, maybe even 20/22 post-mvp if we're ok not being on a LTS release for a few months

How to test this PR

• make sure you're using node 18, if you're using nvm, it's nvm use 18
• make sure you're using the prescribed version of yarn, it's yarn set version 4.1.1 or use corepack
• does vite still build things correctly? yarn run dev
• can you run your tests locally? yarn test

Screenshots

Before

After

[billhimmelsbach]

Confirmed there's no node version stated in the DDD, so we're good to go for a review for this one @shindigira and @meissadia 👍

[meissadia]

Tests run successfully 👌🏾

I was trying to update .nvmrc but accidentally pushed the commit to branch 418-bump-deps-for-security-audit instead of this one 😞

[billhimmelsbach]

Tests run successfully 👌🏾

I was trying to update .nvmrc but accidentally pushed the commit to branch 418-bump-deps-for-security-audit instead of this one 😞

Good catch though on the .nvmrc file over here. I'll merge this one, and then we can incorporate that change in that other PR?

[billhimmelsbach]

Ok, I went ahead and put the .nvmrc commit over here, so good to go! 👍