Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): bump deps to avoid subdependency problems #419

Merged
merged 14 commits into from Apr 30, 2024

Conversation

billhimmelsbach
Copy link
Contributor

@billhimmelsbach billhimmelsbach commented Apr 24, 2024

We have some two moderate security issues with current subdependencies that would be good to fix before the cybersecurity audits. I found the deps that had the subdependencies that were causing the issues and upped their versions to the minimum version that didn't have the security issues: a little nicer than just using resolutions to override the subdependencies.

Changes

  • "axios": "^1.6.7" => "axios": "^1.6.8"
  • "start-server-and-test": "2.0.0" => "start-server-and-test": "^2.0.3"
  • "vitest": "0.31.0" => "vitest": "^0.34.6"
  • "vite": "^4.4.9" => "vite": "^4.5.3"
  • "@vitejs/plugin-react": "4.0.0" => "@vitejs/plugin-react": "4.2.1"

How to test this PR

  1. Checkout the PR
  2. Run yarn install
  3. Run yarn npm audit
  4. Success! 🎉

Screenshots

Current behavior

Screenshot 2024-04-24 at 11 56 38 AM

Expected behavior

Screenshot 2024-04-24 at 11 57 01 AM

shindigira
shindigira previously approved these changes Apr 24, 2024
Copy link
Contributor

@shindigira shindigira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clears yarn npm audit purrrrfectly 😸

Screenshot 2024-04-24 at 1 36 37 PM

@billhimmelsbach
Copy link
Contributor Author

billhimmelsbach commented Apr 24, 2024

Going to need to fix some vitest issues... 😔

@shindigira shindigira self-requested a review April 24, 2024 23:24
@billhimmelsbach
Copy link
Contributor Author

So this vitest error...
Screenshot 2024-04-27 at 4 41 54 PM
...was caused by @vitejs/plugin-react package being out of date. Updated that and everything works great.

I did find some problems with how tests run locally, which I spun off into its own PR over here.

Ready for re-review @shindigira!

shindigira
shindigira previously approved these changes Apr 29, 2024
Copy link
Contributor

@shindigira shindigira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with node 16, yarn install and yarn npm audit.

Screenshot 2024-04-29 at 9 29 06 AM

meissadia
meissadia previously approved these changes Apr 29, 2024
Copy link
Collaborator

@meissadia meissadia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All clear!

@meissadia meissadia dismissed stale reviews from shindigira and themself via 500872e April 29, 2024 21:51
@billhimmelsbach
Copy link
Contributor Author

billhimmelsbach commented Apr 30, 2024

After a little shuffling, I removed the .nvmrc change from this commit and moved it over here.

@meissadia meissadia self-requested a review April 30, 2024 17:46
Copy link
Collaborator

@meissadia meissadia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry about the commit-to-the-wrong-branch!

Audit still clear. 👍🏾

@billhimmelsbach
Copy link
Contributor Author

billhimmelsbach commented Apr 30, 2024

Sorry about the commit-to-the-wrong-branch!

Audit still clear. 👍🏾

No worries! Thanks for the quick re-review @meissadia!

@billhimmelsbach billhimmelsbach merged commit 2cc433a into main Apr 30, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants