Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added an attempt to set UPLOAD_FAILED in except block, and logging if… #197

Merged
merged 1 commit into from
May 7, 2024
Merged

Added an attempt to set UPLOAD_FAILED in except block, and logging if… #197

merged 1 commit into from
May 7, 2024

Conversation

jcadam14
Copy link
Contributor

@jcadam14 jcadam14 commented May 6, 2024

Closes #180

@jcadam14 jcadam14 self-assigned this May 6, 2024
@jcadam14 jcadam14 linked an issue May 6, 2024 that may be closed by this pull request
Fix exception handling in POST /submission #180
Closed
@github-actions GitHub Actions
Copy link

github-actions bot commented May 6, 2024

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)		Lines missing
  src/sbl_filing_api/routers
  filing.py
Project Total  

This report was generated by python-coverage-comment-action

@hkeeler hkeeler merged commit c823e0f into main May 7, 2024
3 checks passed
@hkeeler hkeeler deleted the 180-fix-exception-handling-in-post-submission branch May 7, 2024 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hkeeler hkeeler hkeeler approved these changes

@guffee23 guffee23 Awaiting requested review from guffee23

@lchen-2101 lchen-2101 Awaiting requested review from lchen-2101

@nargis-sultani nargis-sultani Awaiting requested review from nargis-sultani

Assignees

@jcadam14 jcadam14

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix exception handling in POST /submission
2 participants
@jcadam14 @hkeeler