Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix exception handling in POST /submission #180

Closed
jcadam14 opened this issue Apr 24, 2024 · 0 comments · Fixed by #197
Closed

Fix exception handling in POST /submission #180

jcadam14 opened this issue Apr 24, 2024 · 0 comments · Fixed by #197
Assignees

Comments

@jcadam14
Copy link
Contributor

jcadam14 commented Apr 24, 2024

Because this exception handling could happen after storing the submission object in the database, there is a possibility of a submission being in the SUBMISSION_STARTED or SUBMISSION_UPLOAD state. Easiest thing is to set the UPLOAD_FAILED state, but it's possible this won't do anything if the issue is in database updates. But best to at least try. Another option would be to remove a created SUBMISSION if an exception hits here so that a submission isn't stuck in some state, but again if the issue is with updating a database, not much chance of that working.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant