Migrate custom BEM to getBEM syntax #1919
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Thanks for the improvements! Browse a preview of your changes using the link below.
To edit notification comments on pull requests, go to your Netlify site configuration. |
anselmbradford
force-pushed
the
ans_update_bem
branch
from
499b1da
to
9888727
Compare
anselmbradford
force-pushed
the
ans_update_bem
branch
from
9888727
to
5c3f0b5
Compare
anselmbradford
force-pushed
the
ans_update_bem
branch
4 times, most recently
from
6a480ec
to
1262d34
Compare
anselmbradford
force-pushed
the
ans_update_bem
branch
8 times, most recently
from
0dd6bce
to
4ac0bcf
Compare
anselmbradford
force-pushed
the
ans_update_bem
branch
2 times, most recently
from
9fb7c38
to
f78e1ab
Compare
anselmbradford
force-pushed
the
ans_update_bem
branch
5 times, most recently
from
ba13b2e
to
1a179e1
Compare
anselmbradford
force-pushed
the
ans_update_bem
branch
from
1a179e1
to
f71842e
Compare
anselmbradford
force-pushed
the
ans_update_bem
branch
from
f71842e
to
3581ed6
Compare
wpears
approved these changes
Apr 16, 2024
There was a problem hiding this comment.
This is looking good! My main worry here is how breaking this change is for dependents, eg design-system-react and cfgov.
Does this warrant a major version bump? Otherwise, we need to make sure dependents are pinned to something before the next release (true for cfgov, not for d-s-r, until cfpb/design-system-react#336 goes in).
|
cc @billhimmelsbach @meissadia no rush but y'all will need to update DSR at some point |
anselmbradford
force-pushed
the
ans_update_bem
branch
from
bac3b9c
to
244ba3d
Compare
anselmbradford
force-pushed
the
ans_update_bem
branch
from
244ba3d
to
9920f62
Compare
This was referenced Apr 18, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
__and modifiers with a double dash--.Testing