Pin underlying design-system deps to latest #336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpears
requested review from
meissadia,
shindigira and
billhimmelsbach
as code owners
❌ Deploy Preview for cfpb-design-system-react failed.
|
anselmbradford
approved these changes
Apr 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, carat matching is used for the DS dep. Because of how the DS is using semver, this means it will always pull in the latest, when that might be breaking. Particularly, cfpb/design-system#1919 will need to be incorporated here to not cause breakages once that gets merged.
Another solution is to use semver more correctly in the DS, ie, put anything breaking behind a major version update. But for now, this PR is nice defense against changes there.