Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Retirement: BEM fixes #8353

Merged
merged 1 commit into from
Apr 30, 2024
Merged

Retirement: BEM fixes #8353

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
11 changes: 3 additions & 8 deletions cfgov/unprocessed/apps/retirement/css/claiming.less
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -258,8 +258,7 @@
}
}

#age-selector-response,
#age-selector-response .thank-you {
#age-selector-response {
display: none;
}

Expand Down Expand Up @@ -303,7 +302,7 @@
display: none;
}

.step-two .lifestyle-btn__active {
.step-two .lifestyle-btn--active {
background-color: var(--navy);
}

Expand Down Expand Up @@ -362,16 +361,12 @@
}
}

.step-three .helpful-btn {
width: 4em;
}

/* cf-notification */
.m-notification {
margin-bottom: 20px;
}

.step-one .notification-input__warning {
.step-one .notification-input-warning {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this and the others like it be --warning?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wpears No, I was second-guessing this too, but this isn't a m-notification class, therefore it's not part of the m-notification block and is its own block, notification-input-warning.

The existing markup looks like this:

Screenshot 2024-04-30 at 8 03 07 AM

It is neither an element of m-notification, nor a modifier on another class. It should probably be re-written as a field-level alert, but that's a separate issue.

border-color: var(--gold);
}

Expand Down
4 changes: 2 additions & 2 deletions cfgov/unprocessed/apps/retirement/js/views/graph-view.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,9 +209,9 @@ function initIndicator() {
function highlightAgeFields(bool) {
const $ageFields = $('#bd-day, #bd-month, #bd-year');
if (bool) {
$ageFields.addClass('notification-input__warning');
$ageFields.addClass('notification-input-warning');
} else {
$ageFields.removeClass('notification-input__warning');
$ageFields.removeClass('notification-input-warning');
}
}

Expand Down
4 changes: 2 additions & 2 deletions cfgov/unprocessed/apps/retirement/js/views/questions-view.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,8 @@ function init() {
const $container = $(this).closest('.question');
const respTo = $(this).val();

$container.find('.lifestyle-btn').removeClass('lifestyle-btn__active');
$(this).addClass('lifestyle-btn__active');
$container.find('.lifestyle-btn').removeClass('lifestyle-btn--active');
$(this).addClass('lifestyle-btn--active');

$container.find('.lifestyle-img').slideUp();
$container
Expand Down