Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retirement: BEM fixes #8353

Merged
merged 1 commit into from Apr 30, 2024
Merged

Retirement: BEM fixes #8353

merged 1 commit into from Apr 30, 2024

Conversation

anselmbradford
Copy link
Member

Additional cleanup followup to #8274

Removals

  • Removes unused thank-you class.
  • Remves unused helpful-btn class.

Changes

  • Update lifestyle-btn__active to lifestyle-btn--active modifier.
  • Update notification-input__warning to notification-input-warning block.

How to test this PR

  1. http://localhost:8000/consumer-tools/retirement/before-you-claim/ should show golden border around age inputs when date is incorrect (put in letters, for example).

/* cf-notification */
.m-notification {
margin-bottom: 20px;
}

.step-one .notification-input__warning {
.step-one .notification-input-warning {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this and the others like it be --warning?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wpears No, I was second-guessing this too, but this isn't a m-notification class, therefore it's not part of the m-notification block and is its own block, notification-input-warning.

The existing markup looks like this:

Screenshot 2024-04-30 at 8 03 07 AM

It is neither an element of m-notification, nor a modifier on another class. It should probably be re-written as a field-level alert, but that's a separate issue.

@anselmbradford anselmbradford added this pull request to the merge queue Apr 30, 2024
Merged via the queue into main with commit 9aef5fe Apr 30, 2024
11 checks passed
@anselmbradford anselmbradford deleted the ans_retirement_bem branch April 30, 2024 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants