Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rgw/notification: Do not log endpoint as it could contain broker user-id & password. #57098

Merged
merged 1 commit into from May 9, 2024

Conversation

kchheda3
Copy link
Contributor

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox
  • jenkins test windows
  • jenkins test rook e2e

@kchheda3 kchheda3 requested a review from a team as a code owner April 25, 2024 22:36
@kchheda3 kchheda3 requested a review from yuvalif April 25, 2024 22:36
@kchheda3 kchheda3 self-assigned this Apr 25, 2024
@github-actions github-actions bot added the rgw label Apr 25, 2024
@thuvh
Copy link

thuvh commented Apr 29, 2024

can we log only host:port and username?

@yuvalif
Copy link
Contributor

yuvalif commented Apr 30, 2024

can we log only host:port and username?

agree

… password.

Signed-off-by: kchheda3 <kchheda3@bloomberg.net>
@kchheda3
Copy link
Contributor Author

kchheda3 commented May 1, 2024

can we log only host:port and username?

agree

port is embed inside endpoint and username is embed either inside endpoint or in the attribute and it would require the same regex approach to de-couple them as used by

can we log only host:port and username?

agree

done

@ivancich ivancich added the wip-eric-testing-1 for ivancich testing label May 6, 2024
@ivancich
Copy link
Member

ivancich commented May 9, 2024

@kchheda3 and @yuvalif : Just want to verify that this does not need backports.

@ivancich ivancich merged commit 29e77ea into ceph:main May 9, 2024
11 checks passed
@kchheda3
Copy link
Contributor Author

kchheda3 commented May 9, 2024

@kchheda3 and @yuvalif : Just want to verify that this does not need backports.

might be better to just backport this to squid

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants