Skip to content

Commit

Permalink
Merge pull request #57098 from kchheda3/wip-dont-log-passwd
Browse files Browse the repository at this point in the history
rgw/notification: Do not log endpoint as it could contain broker user-id & password.

Reviewed-by: Yuval Lifshitz <ylifshit@ibm.com>
  • Loading branch information
ivancich committed May 9, 2024
2 parents f809df2 + 34da6f9 commit 29e77ea
Showing 1 changed file with 7 additions and 1 deletion.
8 changes: 7 additions & 1 deletion src/rgw/driver/rados/rgw_notify.cc
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
#include "rgw_perf_counters.h"
#include "services/svc_zone.h"
#include "common/dout.h"
#include "rgw_url.h"
#include <chrono>

#define dout_subsys ceph_subsys_rgw_notification
Expand Down Expand Up @@ -71,9 +72,14 @@ WRITE_CLASS_ENCODER(event_entry_t)

static inline std::ostream& operator<<(std::ostream& out,
const event_entry_t& e) {
std::string host;
std::string user;
std::string password;
parse_url_authority(e.push_endpoint, host, user, password);
return out << "notification id: '" << e.event.configurationId
<< "', topic: '" << e.arn_topic
<< "', endpoint: '" << e.push_endpoint
<< "', endpoint: '" << host
<< "', endpoint_user: '" << user
<< "', bucket_owner: '" << e.event.bucket_ownerIdentity
<< "', bucket: '" << e.event.bucket_name
<< "', object: '" << e.event.object_key
Expand Down

0 comments on commit 29e77ea

Please sign in to comment.