Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

squid: librbd: make group and group snapshot IDs more random #57092

Merged
merged 1 commit into from
May 8, 2024

Commits on Apr 25, 2024

  1. librbd: make group and group snapshot IDs more random

    Image IDs suffered from the same issue -- it was addressed in commit
    be83736 ("librbd: block_name_prefix is not created randomly").
    The code for generating group IDs is duplicated in api/Group.cc and
    got missed.
    
    Instead of cut-and-pasting the fix, just call generate_image_id()
    directly and rename variables for more explicitness.
    
    Before:
    
      $ rados -p rbd ls | grep rbd_group_header
      rbd_group_header.10256b8b4567
      rbd_group_header.10216b8b4567
      rbd_group_header.10236b8b4567
      rbd_group_header.101f6b8b4567
    
    After:
    
      $ rados -p rbd ls | grep rbd_group_header
      rbd_group_header.10255f555a5
      rbd_group_header.1023f347eafb
      rbd_group_header.101f24c75111
      rbd_group_header.1021dda4e122
    
    Fixes: https://tracker.ceph.com/issues/65573
    Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
    (cherry picked from commit 76ed07d)
    idryomov committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    e5eb925 View commit details
    Browse the repository at this point in the history