squid: librbd: make group and group snapshot IDs more random #57092
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Image IDs suffered from the same issue -- it was addressed in commit be83736 ("librbd: block_name_prefix is not created randomly"). The code for generating group IDs is duplicated in api/Group.cc and got missed. Instead of cut-and-pasting the fix, just call generate_image_id() directly and rename variables for more explicitness. Before: $ rados -p rbd ls | grep rbd_group_header rbd_group_header.10256b8b4567 rbd_group_header.10216b8b4567 rbd_group_header.10236b8b4567 rbd_group_header.101f6b8b4567 After: $ rados -p rbd ls | grep rbd_group_header rbd_group_header.10255f555a5 rbd_group_header.1023f347eafb rbd_group_header.101f24c75111 rbd_group_header.1021dda4e122 Fixes: https://tracker.ceph.com/issues/65573 Signed-off-by: Ilya Dryomov <idryomov@gmail.com> (cherry picked from commit 76ed07d)
trociny
approved these changes
Apr 25, 2024
|
jenkins test make check |
|
jenkins test api |
|
jenkins test windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport tracker: https://tracker.ceph.com/issues/65587
backport of #56987
parent tracker: https://tracker.ceph.com/issues/65573