Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Indexing new contracts #24

Open
wants to merge 31 commits into
base: main
Choose a base branch
from

Conversation

brunomenezes
Copy link
Collaborator

@brunomenezes brunomenezes commented Jan 23, 2024

Summary

Code changes to add index data from contracts and events of interest.

More info:

closes #23

@brunomenezes brunomenezes linked an issue Jan 23, 2024 that may be closed by this pull request
7 tasks
@tuler
Copy link
Member

tuler commented Jan 23, 2024

Looking good so far

@brunomenezes brunomenezes force-pushed the feature/23-indexing-new-providers-contracts branch from 205b9fe to 82560e9 Compare January 26, 2024 07:36
@brunomenezes
Copy link
Collaborator Author

brunomenezes commented Jan 29, 2024

@tuler, I am changing the PR to ready to review, but there are a few things to notice. Even though the diagram has some arrows between ValidatorNodeProvider to Marketplace and also to ApplicationFactory these are actually out because the factory is the Marketplace and the ApplicationFactory is searchable once you have the ValidatorNode, so the final Diagram would be as below. Let me know if the way to reach ApplicationFactory needs to be through the provider and not the ValidatorNode itself.

full_diagram

@brunomenezes brunomenezes marked this pull request as ready for review January 29, 2024 07:33
src/config.ts Outdated Show resolved Hide resolved
src/config.ts Outdated Show resolved Hide resolved
@brunomenezes brunomenezes force-pushed the feature/23-indexing-new-providers-contracts branch from eb3c481 to 887616c Compare February 1, 2024 23:56
Copy link
Member

@tuler tuler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I'll need to navigate from application to the collection of validatorNodes

@brunomenezes
Copy link
Collaborator Author

I think I'll need to navigate from application to the collection of validatorNodes

I merged the PR #25 here that accounts for that and simplify the Entities as we discussed previously.

@brunomenezes brunomenezes self-assigned this Feb 7, 2024
@brunomenezes brunomenezes added the Status: On-Hold On-hold for further development, because upcoming changes will affect the Issue or PR targeted label Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: On-Hold On-hold for further development, because upcoming changes will affect the Issue or PR targeted
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Indexing new providers contracts
2 participants