Refactor: agency card eligibility error #2053
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
front-end
Coverage report
Click to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||||||||||||||
angela-tran
commented
Apr 24, 2024
| {% endblock unverified-headline %} | ||
|
|
||
| {% block unverified-body %} | ||
| {% translate "The number and last name must be entered exactly as they appear on your MST Courtesy Card. Please check your card and try again, or contact your transit agency for help." %} |
There was a problem hiding this comment.
Need to either use a variable here for the agency card name or have a template per agency card flow.
There was a problem hiding this comment.
Decided to have a template per agency card flow. This is more in line with our current pattern where we are ok with some duplication
angela-tran
force-pushed
the
refactor/agency-card-eligibility-error
branch
3 times, most recently
from
68c6b8e
to
2581c54
Compare
angela-tran
changed the base branch from
dev
to
feat/calfresh-enrollment-success
3 tasks
the call-to-action takes the user back to the confirm form.
angela-tran
force-pushed
the
refactor/agency-card-eligibility-error
branch
from
2581c54
to
6ad6894
Compare
thekaveman
approved these changes
Apr 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2013
Currently based onfeat/calfresh-enrollment-successin hopes of avoiding unnecessary merge conflicts withdjango.potimestampspb-5topb-4between the icon and headlineScreenshots
Expand
Figma:
