Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Feat: enrollments can expire (#1989)" #2052

Merged
merged 1 commit into from Apr 25, 2024

Conversation

angela-tran
Copy link
Member

@angela-tran angela-tran commented Apr 24, 2024

This reverts commit 479b249, reversing changes made to 96ea690.

We're reverting the change to how enrollment is performed to unblock other in-progress changes that we'd like to be able to deploy.

This reverts all the logic for looking up funding sources linked to a group, and determining if a user is eligible for re-enrollment. Instead we go back to handling the 409 error that indicates a user is already enrolled in a group, with no logic for expiration.

We are working with Littlepay to identify issues with testing this expiration logic, and will bring these changes back to dev once we solve those issues.

This reverts commit 479b249, reversing
changes made to 96ea690.
@angela-tran angela-tran requested a review from a team as a code owner April 24, 2024 18:59
@github-actions github-actions bot added tests Related to automated testing (unit, UI, integration, etc.) front-end HTML/CSS/JavaScript and Django templates back-end Django views, sessions, middleware, models, migrations etc. deployment-dev [auto] Changes that will trigger a deploy if merged to dev labels Apr 24, 2024
Copy link

github-actions bot commented Apr 24, 2024

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  benefits
  settings.py
  benefits/enrollment
  views.py
Project Total  

This report was generated by python-coverage-comment-action

Copy link
Member

@thekaveman thekaveman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this locally with the Courtesy Card flow, and confirmed that the 409 error was raised and handled during enrollment. I received the success screen.

Copy link
Member Author

@angela-tran angela-tran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was also able to get through enrollment successfully using this branch

@angela-tran angela-tran merged commit ea0dbea into dev Apr 25, 2024
18 checks passed
@angela-tran angela-tran deleted the revert/feat/expiry-date branch April 25, 2024 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
back-end Django views, sessions, middleware, models, migrations etc. deployment-dev [auto] Changes that will trigger a deploy if merged to dev front-end HTML/CSS/JavaScript and Django templates tests Related to automated testing (unit, UI, integration, etc.)
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants