Feat: CalFresh enrollment success with expiration

[thekaveman]

Closes #1919

Todo

Questions sent to @srhhnry in Figma

• Confirm spacing on Desktop: between top heading and image
• Confirm spacing on Mobile: between image and expiry heading, between expiry heading and first paragraph
• Rebase on feat/expiry-date to de-dupe the TIME_ZONE setting change

How to test

1. In the Admin, update a flow that you can pass eligibility for (e.g. MST Courtesy Cards): check supports expiration and add a value for the expiration days, re-enrollment days, and a QA group ID
2. In the Admin, update the corresponding agency's PaymentProcessor to connect to the QA environment
3. Pass eligibility
4. Enroll a test credit card
5. See the new success page

Screenshot - English

Screenshot - Spanish

[github-actions]

Coverage report

Click to see where and how coverage changed

File	Statements	Missing	Coverage	Coverage (new stmts)	Lines missing
benefits
settings.py
benefits/locale/en
formats.py
benefits/locale/es
formats.py
Project Total

This report was generated by python-coverage-comment-action

[thekaveman]

I think we can actually merge this in, as it won't be activated for flows until we get back the expiration logic for enrollment (after #2052). And it doesn't have any conflicts with those changes, it just changed the enrollment/success.html template.

[angela-tran]

To test this locally, I:

• (temporarily) merged dev into my local feat/calfresh-enrollment-success branch so that I have the revert from Revert "Feat: enrollments can expire (#1989)" #2052
• edited my Courtesy Card eligibility type to support expiration
• ran through the full Courtesy Card flow

I then see the success screen:

The expiration date doesn't show because currently there isn't any code that sets the enrollment_expiry session variable, and that's ok because this screen won't be accessible until after #2052 is reverted.

Hard-coding in an enrollment_expiry to test date formatting

Just to test the date-formatting, I hard-coded a value in for expiry in the session.enrollment_expiry function:

    # expiry = request.session.get(_ENROLLMENT_EXP)
    expiry = datetime(2024, 12, 1).timestamp()

English:

Spanish:

@thekaveman Do you know how the date formatting gets set? I'm not sure why I'm getting an abbreviated month in English

[angela-tran]

With a March date, I see the full month name:

[thekaveman]

@angela-tran:

@thekaveman Do you know how the date formatting gets set? I'm not sure why I'm getting an abbreviated month in English

We're using the date filter, which uses the DATE_FORMAT setting by default, which is:

DATE_FORMAT = "N j, Y"

Broken down as (from the table here):

• N: Month abbreviation in Associated Press style. Proprietary extension.
• j: Day of the month without leading zeros.
• Y: Year, 4 digits with leading zeros.

It looks like for N, some months are fully spelled out and others are abbreviated. I guess we should change the default and instead use one of:

• E: Month, locale specific alternative representation usually used for long date representation.
• F: Month, textual, long.

I think each language has its own default format string, so changing this one should only affect English.

[thekaveman]

@angela-tran I rebased on dev so this branch now has the revert from #2052.

I introduced custom date formats per locale and now we get the expected full-month formatting for both English and Spanish:

[angela-tran]

Nice!

[angela-tran]

The coverage report is flagging that the formats.py files aren't tested... should we do something about that?

[thekaveman]

The coverage report is flagging that the formats.py files aren't tested... should we do something about that?

Good call on this! I added tests for each in 9cdacdc

[angela-tran]

🚀

[angela-tran]

Just noticed the infra pipeline failure... looking into it

[angela-tran]

terraform plan failed with Error: Unable to list provider registration status... seems unrelated to this PR's changes

[angela-tran]

Re-ran it and it worked 😂