Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore: update 500 error page #2039

Merged
merged 3 commits into from Apr 19, 2024
Merged

Chore: update 500 error page #2039

merged 3 commits into from Apr 19, 2024
+29 −13

Conversation

thekaveman
Copy link
Member

@thekaveman thekaveman commented Apr 18, 2024 •
edited

Closes #2030

  • Headline and body copy updated
  • All CTAs with text Return Home updated to Return home
  • Spacing between icon and headline fixed
  • Spacing between headline and paragraph already 24px
  • Spacing between paragraph and CTA button already 64px

Reviewing

  1. Update benefits/urls.py as follows:

    - if settings.DEBUG:
+ if True:

  2. Start the app without Debugging

  3. Visit /error

  4. See the updated copy and design

@thekaveman thekaveman self-assigned this Apr 18, 2024
@github-actions github-actions bot added front-end HTML/CSS/JavaScript and Django templates deployment-dev [auto] Changes that will trigger a deploy if merged to dev i18n Copy: Language files or Django i18n framework labels Apr 18, 2024
@github-actions GitHub Actions
Copy link

Coverage report

This PR does not seem to contain any modification to coverable code.

@thekaveman thekaveman marked this pull request as ready for review April 18, 2024 21:19
@thekaveman thekaveman requested a review from a team as a code owner April 18, 2024 21:19
@thekaveman thekaveman mentioned this pull request Apr 18, 2024
Merged
angela-tran
angela-tran previously approved these changes Apr 19, 2024
View reviewed changes
Copy link
Member

@angela-tran angela-tran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great 👍

@thekaveman
Copy link
Member Author

Sorry @angela-tran I had to rebase to clean up some conflicts

@thekaveman thekaveman merged commit 733962d into dev Apr 19, 2024
8 checks passed
@thekaveman thekaveman deleted the chore/500-error-page branch April 19, 2024 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@angela-tran angela-tran angela-tran approved these changes

Assignees

@thekaveman thekaveman

Labels
deployment-dev [auto] Changes that will trigger a deploy if merged to dev front-end HTML/CSS/JavaScript and Django templates i18n Copy: Language files or Django i18n framework
Projects
None yet
Milestone
Improved UX for application error states
Development

Successfully merging this pull request may close these issues.

500 error: update copy, spacing, and casing
2 participants
@thekaveman @angela-tran