Chore: update enrollment retry page #2040
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
tests
Coverage report
Click to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||||||||
5 tasks
thekaveman
force-pushed
the
chore/500-error-page
branch
from
0b6e592
to
e163643
Compare
thekaveman
force-pushed
the
chore/enrollment-retry
branch
from
7daa7a9
to
8284f70
Compare
this change simplifies the view logic and updates the corresponding tests throwing an error on GET is unnecessary: the behavior was a kind of an assertion on how the user got to the /retry route, but in fact it doesn't really matter if they made a GET or POST. Supporting GET makes testing the route easier too.
thekaveman
force-pushed
the
chore/enrollment-retry
branch
from
8284f70
to
a6bf318
Compare
angela-tran
reviewed
Apr 23, 2024
angela-tran
approved these changes
Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2031
The
/retrypage was functioning as both our "user" enrollment error page (i.e. #2031) and our "system" enrollment error page (i.e. #2032).This PR updates the language so the page is more explicitly for "user" enrollment errors.
#2032 will have to make additional changes e.g. by creating a new route/template.
This PR also simplifies the view logic of
/retry, to remove the unnecessary blocking ofGETrequests to that endpoint (which makes testing easier).Current on top of #2039
Reviewing
/enrollment/retry