Fix(models): allow blank #1979
Merged
Fix(models): allow blank #1979
+111
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
migrations
Coverage report
Click to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||
angela-tran
force-pushed
the
fix/allow-blank
branch
from
e059701
to
d78fd32
Compare
in addition to allowing null in the database for this field, forms should allow blank values for this field.
angela-tran
force-pushed
the
fix/allow-blank
branch
from
d78fd32
to
d722818
Compare
thekaveman
requested changes
Mar 22, 2024
There was a problem hiding this comment.
I get that these are only changes that impact the Admin forms, but I still think a migration is required.
- Check out
devand runbin/reset_db.sh(now DB looks like it does ondev) - Check out this branch and run
bin/init.sh(which is what the appcontainer will run indev) - See output:
Operations to perform:
Apply all migrations: admin, auth, contenttypes, core, django_google_sso, sessions
Running migrations:
No migrations to apply.
Your models in app(s): 'core' have changes that are not yet reflected in a migration, and so won't be applied.
Run 'manage.py makemigrations' to make new migrations, and then re-run 'manage.py migrate' to apply them.
Ah, thanks for catching this |
angela-tran
force-pushed
the
fix/allow-blank
branch
from
f3212b6
to
662d621
Compare
thekaveman
requested changes
Mar 25, 2024
There was a problem hiding this comment.
This isn't totally related, but I feel like since you're updating models for editing in the Admin...
It seems like we forgot to list AuthProvider in the models that are registered for editing in the Admin: https://github.com/cal-itp/benefits/blob/dev/benefits/core/admin.py#L19
Do you think you can add that here so we can just be done with it?
2 tasks
this is so AuthProvider can be edited too
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1977
This PR sets
blanktoTruefor all nullable fields on our models. This is so form validation on those fields will allow blank values.