Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: CalFresh enrollment index #1968

Merged
merged 11 commits into from
Apr 1, 2024
Merged

Feat: CalFresh enrollment index #1968

merged 11 commits into from
Apr 1, 2024

Conversation

thekaveman
Copy link
Member

@thekaveman thekaveman commented Mar 21, 2024 •
edited

Closes #1917

Currently on top of #1970 since both PRs introduce new migrations.

Currently on top of #1979 since both PRs introduce new migrations.

Todo

  • Fix spacing between media item and alert box (should be 48px, currently the default of 64px)
  • Fix horizontal alignment of the alert box so it is aligned with the media item

Testing

  • Run bin/init.sh to run migrations
  • Launch the app with F5
  • In the Admin, update the enrollment_index_template for a flow where you can pass eligibility, e.g. MST Courtesy Cards, to be enrollment/index--calfresh.html
  • For the full experience, update the corresponding PaymentProcessor instance to connect to the QA environment
  • Pass eligibility for the flow
  • See the new CalFresh enrollment index with alert box:

image

@thekaveman thekaveman self-assigned this Mar 21, 2024
@github-actions github-actions bot added migrations [auto] Review for potential model changes/needed data migrations updates deployment-dev [auto] Changes that will trigger a deploy if merged to dev tests Related to automated testing (unit, UI, integration, etc.) front-end HTML/CSS/JavaScript and Django templates back-end Django views, sessions, middleware, models, migrations etc. and removed front-end HTML/CSS/JavaScript and Django templates labels Mar 21, 2024
@thekaveman thekaveman added the front-end HTML/CSS/JavaScript and Django templates label Mar 21, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 21, 2024 •
edited

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)		Lines missing
  benefits/core
  models.py
  benefits/enrollment
  views.py
Project Total  

This report was generated by python-coverage-comment-action

@thekaveman thekaveman force-pushed the feat/calfresh-enrollment-index branch from 82daac4 to cb493c3 Compare March 22, 2024 17:18
@thekaveman thekaveman changed the base branch from dev to feat/calfresh-help-info March 22, 2024 17:18
Base automatically changed from feat/calfresh-help-info to dev March 22, 2024 19:44
@thekaveman thekaveman force-pushed the feat/calfresh-enrollment-index branch 2 times, most recently from 3b81d70 to 050b965 Compare March 22, 2024 21:02
@thekaveman thekaveman marked this pull request as ready for review March 25, 2024 22:45
@thekaveman thekaveman requested a review from a team as a code owner March 25, 2024 22:45
@thekaveman thekaveman marked this pull request as draft March 25, 2024 22:48
@thekaveman thekaveman force-pushed the feat/calfresh-enrollment-index branch from b37c648 to 6d2856a Compare March 25, 2024 22:51
@thekaveman thekaveman changed the base branch from dev to fix/allow-blank March 25, 2024 22:51
@thekaveman thekaveman force-pushed the feat/calfresh-enrollment-index branch from 6d2856a to d854a3e Compare March 25, 2024 23:26
Base automatically changed from fix/allow-blank to dev March 25, 2024 23:30
@thekaveman thekaveman marked this pull request as ready for review March 25, 2024 23:32
@thekaveman thekaveman mentioned this pull request Mar 28, 2024
Merged
@angela-tran
Copy link
Member

Reviewing this now

angela-tran
angela-tran requested changes Mar 29, 2024
View reviewed changes
Copy link
Member

@angela-tran angela-tran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Just a small requested change and a question

benefits/static/css/styles.css Outdated Show resolved Hide resolved
benefits/enrollment/templates/enrollment/index.html Show resolved Hide resolved
@thekaveman
feat(enrollment): include the alert-box for the CalFresh index
4ba489c 
update PO files with new English text
@thekaveman
style: override margin on calfresh enrollment index media-list
88b4b7b 
the default for media-list remains 64px

removed an unused style rule for h1 + .media-list, from the old enrollment
success template (since refactored to not use media-list)
@thekaveman
style: alert-box uses more Bootstrap utils
875736e
@thekaveman
style: helper for left margin aligned with media-list text
8e2311e 
calculated based on the width and right margin of media icon
@thekaveman
refactor: calfresh alert-box implements overrides
bba6ad9 
* move the warning class override to calfresh alert-box

* apply the calfresh specific margin class to align alert-box with
  preceding media-list text
@thekaveman
style: call-to-action has padding-top
9b6aa0b
@thekaveman
chore(enrollment): add visible class after removing invisible class
1216af6 
this is just for clarity to make reading the HTML a little more sensible
rather than seeing a div with an empty class attribute

no UX impact
@thekaveman thekaveman force-pushed the feat/calfresh-enrollment-index branch from d854a3e to 1216af6 Compare March 29, 2024 22:18
angela-tran
angela-tran approved these changes Apr 1, 2024
View reviewed changes
Copy link
Member

@angela-tran angela-tran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 💳

@thekaveman thekaveman merged commit 916028a into dev Apr 1, 2024
13 checks passed
@thekaveman thekaveman deleted the feat/calfresh-enrollment-index branch April 1, 2024 22:58
@thekaveman thekaveman mentioned this pull request Apr 29, 2024
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@angela-tran angela-tran angela-tran approved these changes

Assignees

@thekaveman thekaveman

Labels
back-end Django views, sessions, middleware, models, migrations etc. deployment-dev [auto] Changes that will trigger a deploy if merged to dev front-end HTML/CSS/JavaScript and Django templates migrations [auto] Review for potential model changes/needed data migrations updates tests Related to automated testing (unit, UI, integration, etc.)
Projects
None yet
Milestone
Low-income rider enrollment pathway
Development

Successfully merging this pull request may close these issues.

Enrollment index: Update for CalFresh
2 participants
@thekaveman @angela-tran