Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: CalFresh help info #1970

Merged
merged 9 commits into from
Mar 22, 2024
Merged

Feat: CalFresh help info #1970

merged 9 commits into from
Mar 22, 2024

Conversation

angela-tran
Copy link
Member

Closes #1920

This PR implements the help page includes template for CalFresh information. A small refactor was needed to put help_template on EligibilityVerifier instead of TransitAgency so that the help information is not hard-coded for any agency.

Screenshot

image

To test locally

Run ./bin/reset_db.sh to recreate your database with newly updated fixtures. Start your app locally and view Help page.

@angela-tran angela-tran self-assigned this Mar 21, 2024
@angela-tran angela-tran requested a review from a team as a code owner March 21, 2024 01:47
@github-actions github-actions bot added front-end HTML/CSS/JavaScript and Django templates deployment-dev [auto] Changes that will trigger a deploy if merged to dev migrations [auto] Review for potential model changes/needed data migrations updates back-end Django views, sessions, middleware, models, migrations etc. and removed deployment-dev [auto] Changes that will trigger a deploy if merged to dev migrations [auto] Review for potential model changes/needed data migrations updates labels Mar 21, 2024
@angela-tran angela-tran marked this pull request as draft March 21, 2024 01:49
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 21, 2024 •
edited

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)		Lines missing
  benefits/core
  context_processors.py
  models.py
  benefits/eligibility
  forms.py
Project Total  

This report was generated by python-coverage-comment-action

@angela-tran angela-tran marked this pull request as ready for review March 21, 2024 19:32
thekaveman
thekaveman requested changes Mar 21, 2024
View reviewed changes
Copy link
Member

@thekaveman thekaveman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 small change requested, 1 question/suggestion

benefits/core/context_processors.py Show resolved Hide resolved
benefits/core/context_processors.py Outdated Show resolved Hide resolved
@thekaveman thekaveman mentioned this pull request Mar 22, 2024
Merged
2 tasks
@angela-tran
chore(conftest): move test fixtures into conftest
0cd9a1e 
for consistency
@angela-tran
refactor(models): add property to TransitAgency to get active verifiers
d79f06c 
update usage in verifier selection form, context processors, and tests
@angela-tran
test: unit test for helper function
f3fe500 
expected behavior is to return an ordered list of the unique values
thekaveman
thekaveman approved these changes Mar 22, 2024
View reviewed changes
Copy link
Member

@thekaveman thekaveman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice refactor/helpers!

I think it's cool that our help sections will be ordered the same as our verifier selection page now

tests/pytest/eligibility/test_views.py Show resolved Hide resolved
@angela-tran angela-tran merged commit 2bcf0a3 into dev Mar 22, 2024
13 checks passed
@angela-tran angela-tran deleted the feat/calfresh-help-info branch March 22, 2024 19:44
@angela-tran
Copy link
Member Author

angela-tran commented Mar 22, 2024 •
edited

Post-merge needed

@angela-tran angela-tran mentioned this pull request Mar 22, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thekaveman thekaveman thekaveman approved these changes

Assignees

@angela-tran angela-tran

Labels
back-end Django views, sessions, middleware, models, migrations etc. deployment-dev [auto] Changes that will trigger a deploy if merged to dev front-end HTML/CSS/JavaScript and Django templates
Projects
None yet
Milestone
Low-income rider enrollment pathway
Development

Successfully merging this pull request may close these issues.

Help page updates for CalFresh information
2 participants
@angela-tran @thekaveman