Vim mode experimental #264

ed2k · 2019-06-16T04:17:32Z

test to see how this travis works

The keybindings are hardcoded for now, but this is going to change.

Added moveTabLeft and moveTabRight functions, which take a tab ID and try to move the tab as far right or left in the tabOrder as possible. Added previouslyVisitedTab function that switches to the previously selected tab.

with activating input boxes using link hinting.

…m-mode-experimental

In Firefox 63 an old syntax for Marionette commands was deprecated. Updating mostly just meant prepending `WebDriver` to existing commands. This should fix most problems in browsh-org#232

Vim mode still needs a lot more tests

…to key combinations only working after a certain number of key strokes.

tombh · 2019-06-17T05:36:15Z

Tests! Wow, this is so great to see you doing this :) If you can get all the main functionality of Vim Mode tested then we can merge it into master.

ed2k · 2019-06-17T06:07:34Z

would like to restruct the integration test to have less restart of firefox, or having a deterministic way of cleanup/init everything. right now not easy to get a pass with 23 tests in tty.

…

On Sun, Jun 16, 2019, 10:36 PM Thomas Buckley-Houston < ***@***.***> wrote: Tests! Wow, this is so great to see you doing this :) If you can get all the main functionality of Vim Mode tested then we can merge it into master. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#264?email_source=notifications&email_token=AAAS6LPZMO6D2S7SDOCZZF3P24PFTA5CNFSM4HYQKPT2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODX2CUUI#issuecomment-502540881>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAAS6LIXA6TCSI7YAF3S2BLP24PFTANCNFSM4HYQKPTQ> .

tombh · 2019-06-17T06:22:08Z

Exactly. That's why we have the flake retries set to 3, I think that could actually be set higher. I actually recently spent a lot of time looking into it. I'm fairly confident that most of the failures are real, as in those are actual real bugs in Browsh being surfaced by the tests. This means that the test runner itself is actually probably pretty reliable. So the best thing would be to actually fix the bugs in Browsh (or just increase the flake retry attempts to 6! haha). For example one of the most annoying bugs is where text doesn't get rendered, that's been a problem for months that you sometimes see when using Browsh yourself. So once bugs like that get fixed the tests will become much more reliable.

See spf13/viper#635

tombh · 2019-06-24T05:42:33Z

webext/src/dom/manager.js

@@ -210,15 +212,32 @@ export default class extends utils.mixins(CommonMixin, CommandsMixin) {
    let target = document.querySelector("body");
    let observer = new MutationObserver(mutations => {
      mutations.forEach(mutation => {
+        if (!target) {


Interesting! Can you tell me more about this bit?

I see type error from logs, makes me believe the body node some times doesn't exist at that time.

tombh · 2019-06-24T06:21:53Z

Could you rebase the vim-mode-experimental branch into this branch. I just updated it with all the recent changes from master. I think that should help clean the commits up here so I can better see what you've specifically added.

ed2k · 2019-06-25T02:02:18Z

Could you rebase the vim-mode-experimental branch into this branch. I just updated it with all the recent changes from master. I think that should help clean the commits up here so I can better see what you've specifically added.

my changes,

more clean logging to catch some error from extention, such as disable keyboard and mouse event logs, log frame_text text content.
merge two vim PR,
merge vim_test into tty_test, seems to be if not these two suite will have some kind of race condition (i.e not executing one after another)
adjust code/test here and there trying to get reliable pass in my local ubuntu with statup_url set to localhost:4444 (instead of browsh.com)

dvd42 · 2019-09-12T13:28:32Z

I started to use browsh and I love the idea. But this is the key feaure missing for me since the default mappings wont all work inside my Tmux. So, any news on when this will be released? Or is there a way I can try this version (with the Vim mappins) by compiling from source?

P.S: Thanks for creating and mantaining this great project 😃

tombh · 2019-09-12T15:20:11Z

@dvd42 You can always just try installing Vim Vixen yourself with Browsh's Firefox in GUI mode (so you can actually install normal Firefox extensions): https://www.brow.sh/docs/extensions/

@ed2k Again apologies for the delay. I just don't have the mental bandwidth at the moment to digest the significance of this work :'(

dvd42 · 2019-09-12T16:08:45Z

@tombh, thanks for the swift reply. I tried this approach and it doesnt seem to work. The new keybindings dont do anything. I tried it both with Vim vixen and Vimium-ff. Any ideas?

tobimensch and others added 30 commits October 7, 2018 14:45

Added new vimium.js with code taken from vimium

bdd0df1

Created overlayVimMode function for displaying vim navigation state

ced1379

gofmt code

6bd4c96

added command for links hints

a78d98b

Set default DISPLAY environment variable for xclipboard functionality

8b35a68

ignore manifest.json backup file

3c8afed

ignore debug log in interfacer/ directory

a04bdac

Fixed typo in comment

0d2dfee

Added sessions permission

9329c9f

Added initial configuration for vim like keybindings.

c40c724

The keybindings are hardcoded for now, but this is going to change.

Added duplicate_tab, restore_tab commands.

f730983

Refactored code using switchToTab and added new features.

b78d896

Added moveTabLeft and moveTabRight functions, which take a tab ID and try to move the tab as far right or left in the tabOrder as possible. Added previouslyVisitedTab function that switches to the previously selected tab.

Added features needed for vim like navigation to the webextension.

052aecd

Added vim like navigation. This is still in an early stage.

4099f51

Instead of adding 1 to Y coord, add 1 to height. This fixes an issues

721b2c8

with activating input boxes using link hinting.

Merge branch 'master' of https://github.com/browsh-org/browsh into vi…

d037732

…m-mode-experimental

Prettified js files

61cd7e1

Fixed typo

ae1df35

Update Go dep to v0.5.0

034d9c4

Newer NVM formats package.lock differently

11f746b

Update FF Marionette commands

d17cb59

In Firefox 63 an old syntax for Marionette commands was deprecated. Updating mostly just meant prepending `WebDriver` to existing commands. This should fix most problems in browsh-org#232

Update JS and Go deps. Bump Browsh to v1.5.0

bf44f91

Adds Golang clipboard dep

0bda8f1

Refactors Vim code from tty.go into its own file

6f998be

Adds some Vim-specific integration tests

e3568cd

Fixes tests for Vim mode

3beeb76

Vim mode still needs a lot more tests

Vim mode: convert unexported symbols to lowercase

26e9c61

Vim mode: Small updates from PR review

af487ae

Travis CI: Bash timeout for integration tests

15f541c

Fixed bug where keyEvents variable was initialized wrongly. This led …

565e6f4

…to key combinations only working after a certain number of key strokes.

Your Name added 3 commits June 15, 2019 12:24

Merge remote-tracking branch 'origin/vim-mode-experimental'

ffa586c

use test script from master

76e7eb1

move vim test into tty test seems helpful

36ac818

tombh and others added 13 commits June 18, 2019 21:19

Fix for Viper's lowercasing of config keys :/

f290601

See spf13/viper#635

Merge remote-tracking branch 'origin/master' into vim-mode-experimental

8363581

test

a937e46

clarify dev path

9797f40

timestamp, wait for body

d9251ec

add test delay for tab

7a39926

better logging and improve tab test stability

0c57d3c

Merge branch 'vim-mode-experimental' into localtest

fae952b

merge vim mode code

b9b6270

changed by prettier

fdf57cd

get another version of prettier

bfdc1d1

Merge remote-tracking branch 'ed2k/vim-mode-experimental' into localtest

a1bbf9b

get another version of prettier

2206efb

tombh reviewed Jun 24, 2019

View reviewed changes

tombh force-pushed the vim-mode-experimental branch from 0c0b907 to b2ade39 Compare June 24, 2019 06:19

ed2k and others added 2 commits June 24, 2019 20:39

Merge branch 'vim-mode-experimental' into vim-mode-experimental

5dc678e

merge vim_test into tty_test

21081ad

tombh mentioned this pull request Jul 16, 2022

Follow links using keyboard. #431

Closed

tombh mentioned this pull request Jul 26, 2022

Vim Mode 2022 #439

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Vim mode experimental #264

Vim mode experimental #264

ed2k commented Jun 16, 2019

tombh commented Jun 17, 2019

ed2k commented Jun 17, 2019 via email

tombh commented Jun 17, 2019

tombh Jun 24, 2019

ed2k Jun 25, 2019

tombh commented Jun 24, 2019

ed2k commented Jun 25, 2019

dvd42 commented Sep 12, 2019 •

edited

tombh commented Sep 12, 2019

dvd42 commented Sep 12, 2019

Vim mode experimental #264

Are you sure you want to change the base?

Vim mode experimental #264

Conversation

ed2k commented Jun 16, 2019

tombh commented Jun 17, 2019

ed2k commented Jun 17, 2019 via email

tombh commented Jun 17, 2019

tombh Jun 24, 2019

Choose a reason for hiding this comment

ed2k Jun 25, 2019

Choose a reason for hiding this comment

tombh commented Jun 24, 2019

ed2k commented Jun 25, 2019

dvd42 commented Sep 12, 2019 • edited

tombh commented Sep 12, 2019

dvd42 commented Sep 12, 2019

dvd42 commented Sep 12, 2019 •

edited