Vim Mode 2022 #439
Open
Vim Mode 2022 #439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The keybindings are hardcoded for now, but this is going to change.
Added moveTabLeft and moveTabRight functions, which take a tab ID and try to move the tab as far right or left in the tabOrder as possible. Added previouslyVisitedTab function that switches to the previously selected tab.
with activating input boxes using link hinting.
…m-mode-experimental
In Firefox 63 an old syntax for Marionette commands was deprecated. Updating mostly just meant prepending `WebDriver` to existing commands. This should fix most problems in #232
Vim mode still needs a lot more tests
…to key combinations only working after a certain number of key strokes.
with activating input boxes using link hinting.
Vim mode still needs a lot more tests
…to key combinations only working after a certain number of key strokes.
This is because Travis' logs had 2 problems. 1. it doesn't capture the entire log output 2. it doesn't show logs when there's a timeout
… event could get interpreted repeatedly. Also some rewrites/improvements of the code. Key mappings can now contain control characters and meta keys with a vim-like notation. There's a hard insert mode, which disables all of browsh's shortcuts and requires 4 hits on ESC to leave. There's a new multiple link opening feature analogous to vimium, that's still incomplete.
After nearly 4 years I'm finally getting round to shipping all the tremendous hard work of @tobimensch, @j-rewerts and @ed2k. I can't apologise enough that it's taken so long.
Open
|
do you want to community to use and test for your fork prior to merge? |
|
vimium in browsh will be a game changer for me! |
|
I was having trouble building this branch with the provided documentation. I assume the repo has a GitHub Action that successfully builds? |
|
I would love help with this. The only thing that needs fixing to get this merged is the failing tests. @jivank The local dev setup docs do indeed need updating. If you're on Linux or similar you can use https://github.com/browsh-org/browsh/blob/master/.github/workflows/main.yml for inspiration. |
|
I see in TTY tests: This is a similar error I was facing when I was attempting to build it on my local machine. |
This was referenced Jan 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Can I finally get Vim Mode merged?
Fixes #236, #246 and #264