Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated to use PyQt6 instead of PyQt5 #132

Open
wants to merge 2 commits into
base: vnc
Choose a base branch
from

Conversation

monkeyclass
Copy link

As PyQt5 is not compatible with M1 Macs, this PR changes to use PyQt6.

At the moment I've gotten as far as to load the the screen from the Remarkable, but something fails then.

Most of the changes are related to qt6 has changed references to most functions, with intermediate functions.

This fixes #119

@bordaigorl
Copy link
Owner

Wow this is amazing, thanks so much for the effort!
I'll try to have a look soon and see if I can help.

@bordaigorl
Copy link
Owner

A quick test works on my machine.
Many interactions crash because they still use the old object hierarchy.
Is there no tool around that can trigger warnings statically for breaking changes between qt5 and qt6?

@monkeyclass
Copy link
Author

A quick test works on my machine.
Many interactions crash because they still use the old object hierarchy.
Is there no tool around that can trigger warnings statically for breaking changes between qt5 and qt6?

I’m not sure, would be great. Completely agree that it’s a bit slow process. I will get around to looking at it again next week, and hopefully get the rest replaced.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't install PyQt5- Python 3.8/3.9 - Mac M1
2 participants