Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SM-1119: Rename service accounts to machine accounts #3958

Merged
merged 2 commits into from Apr 5, 2024
Merged

Conversation

coltonhurst
Copy link
Member

@coltonhurst coltonhurst commented Apr 4, 2024

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

Renaming service accounts to machine accounts.

Web PR: bitwarden/clients#8444

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • If making database changes - make sure you also update Entity Framework queries and/or migrations
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

@coltonhurst coltonhurst self-assigned this Apr 4, 2024
Copy link

codecov bot commented Apr 4, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 36.70%. Comparing base (6242c25) to head (f5e9fc7).

Files Patch % Lines
...iptions/UpdateSecretsManagerSubscriptionCommand.cs 69.23% 4 Missing ⚠️
.../Services/Implementations/HandlebarsMailService.cs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3958   +/-   ##
=======================================
  Coverage   36.70%   36.70%           
=======================================
  Files        1174     1174           
  Lines       56672    56672           
  Branches     5436     5436           
=======================================
  Hits        20804    20804           
  Misses      34903    34903           
  Partials      965      965           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@vincentsalucci vincentsalucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed AC owned files 👍

Copy link
Contributor

@Thomas-Avery Thomas-Avery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

github-actions bot commented Apr 4, 2024

Logo
Checkmarx One – Scan Summary & Detailsd05c4c05-99fa-4dc1-9541-6ad7351e5755

No New Or Fixed Issues Found

@coltonhurst
Copy link
Member Author

Note: QA will be done on the main branch.

@coltonhurst coltonhurst merged commit b164f24 into main Apr 5, 2024
50 checks passed
@coltonhurst coltonhurst deleted the sm/sm-1119 branch April 5, 2024 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants