SM-1159: Rename Service Accounts to Machine Accounts #8444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8444 +/- ##
=======================================
Coverage 27.15% 27.15%
=======================================
Files 2330 2330
Lines 67945 67943 -2
Branches 12693 12691 -2
=======================================
Hits 18448 18448
+ Misses 48103 48101 -2
Partials 1394 1394 ☔ View full report in Codecov by Sentry. |
apps/web/src/app/billing/organizations/sm-adjust-subscription.component.html
Show resolved
Hide resolved
r-tome
reviewed
Mar 27, 2024
|
New Issues
|
@r-tome for now we want to keep the old entries. The main reason for this is if we want to switch back to service accounts, this will be easy, especially as it means we can also keep the translations. |
|
Merged branch |
dani-garcia
previously approved these changes
Apr 3, 2024
cturnbull-bitwarden
previously approved these changes
Apr 3, 2024
r-tome
previously approved these changes
Apr 3, 2024
5 tasks
coltonhurst
dismissed stale reviews from r-tome, cturnbull-bitwarden, dani-garcia, and Thomas-Avery
via
0cc09f3
Thomas-Avery
approved these changes
Apr 4, 2024
dani-garcia
approved these changes
Apr 5, 2024
cturnbull-bitwarden
approved these changes
Apr 5, 2024
vincentsalucci
approved these changes
Apr 5, 2024
|
Note: QA will test on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Objective
Rename Service Accounts to Machine Accounts. In this PR we create new i18n entries, preserving the Service Account ones purposely for easy rollback and to keep the translations. Please note, this refactor only applies to text that is visible to the user, for now the code base still refers to these types of accounts as Service Accounts.
Server PR: bitwarden/server#3958
Code changes
Only added new i18n entries and swapped the old ones for the new ones. Everything should be the same except Service Account becomes Machine Account, with the casing kept based on the initial message.
Before you submit