Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PM-7048] Disable relaunch on MAS #8466

Merged
merged 1 commit into from Mar 25, 2024
Merged

[PM-7048] Disable relaunch on MAS #8466

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 5 additions & 1 deletion apps/desktop/src/main/menu/menu.help.ts
View file
Open in desktop
Expand Up @@ -240,7 +240,11 @@
await this.desktopSettingsService.setHardwareAcceleration(
!this.hardwareAccelerationEnabled,
);
app.relaunch();
// `app.relaunch` crashes the app on Mac Store builds. Disabling it for now.
// https://github.com/electron/electron/issues/41690
if (!isMacAppStore()) {
app.relaunch();

Check warning on line 246 in apps/desktop/src/main/menu/menu.help.ts

View check run for this annotation

Codecov / codecov/patch

apps/desktop/src/main/menu/menu.help.ts#L246 

Added line #L246 was not covered by tests
}
app.exit();
},
},
Expand Down