Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-7048] Disable relaunch on MAS #8466

Merged
merged 1 commit into from Mar 25, 2024
Merged

[PM-7048] Disable relaunch on MAS #8466

merged 1 commit into from Mar 25, 2024

Conversation

Hinton
Copy link
Member

@Hinton Hinton commented Mar 25, 2024

Type of change

- [x] Bug fix
- [ ] New feature development
- [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [ ] Other

Objective

Running app.relaunch crashes on mac app store builds. Disabling it for now while we track electron/electron#41690. Unfortunately this means MAS users will have to manually start the app after it quits.

Before you submit

  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team
  • Ensure that all UI additions follow WCAG AA requirements

@Hinton Hinton requested a review from MGibson1 March 25, 2024 14:08
@github-actions github-actions bot added the needs-qa Marks a PR as requiring QA approval label Mar 25, 2024
Copy link

codecov bot commented Mar 25, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 26.32%. Comparing base (9243bb9) to head (83ea70f).

Files Patch % Lines
apps/desktop/src/main/menu/menu.help.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8466      +/-   ##
==========================================
- Coverage   26.32%   26.32%   -0.01%     
==========================================
  Files        2302     2302              
  Lines       67366    67367       +1     
  Branches    12630    12631       +1     
==========================================
  Hits        17735    17735              
- Misses      48248    48249       +1     
  Partials     1383     1383              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Hinton Hinton changed the title Disable relaunch on MAS [PM-7048] Disable relaunch on MAS Mar 25, 2024
@Hinton Hinton removed the needs-qa Marks a PR as requiring QA approval label Mar 25, 2024
@Hinton Hinton merged commit 8639f49 into main Mar 25, 2024
36 of 37 checks passed
@Hinton Hinton deleted the ps/crash-mas branch March 25, 2024 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants