purple: add defer_joins, use_matrix_alias and name_with_tag options #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(Most of these changes are aimed at making matrix not a pain to use) - The `defer_joins` option on prpl accounts waits for users to be added to a prpl conversation before adding the bitlbee user, in the hope of being able to get some chat name/alias metadata before doing so. - (To that end, the name hint for rooms is now updated when users are added.) - The `name_with_tag` options prefixes the account tag to the name hint for prpl accounts, in order to namespace prpl channels somewhat. - The `use_matrix_alias` option is specialized for the purple-matrix plugin, and makes the name hint use the `matrix_alias` data item of the prpl conversation, instead of the title.
dequis
reviewed
Apr 4, 2019
| @@ -1171,7 +1205,7 @@ static void handle_conv_msg(PurpleConversation *conv, const char *who, const cha | |||
| { | |||
| struct im_connection *ic = purple_ic_by_pa(conv->account); | |||
| struct groupchat *gc = conv->ui_data; | |||
| char *message = g_strdup(message_); | |||
| char *message = purple_unescape_html(message_); | |||
There was a problem hiding this comment.
Note to self: This seems unlikely to be desirable for all prpls. I think there's a prpl flag to mark it as sending html or not?
| @@ -1133,7 +1158,12 @@ void prplcb_conv_new(PurpleConversation *conv) | |||
| /* libpurple brokenness: Whatever. Show that we join right away, | |||
| there's no clear "This is you!" signaling in _add_users so | |||
| don't even try. */ | |||
| imcb_chat_add_buddy(gc, gc->ic->acc->user); | |||
| if (!set_getbool(&(ic->acc->set), "defer_joins")) { | |||
There was a problem hiding this comment.
Note to self: Considering the comment above, I wonder if this should be default behavior, because yeah, this ugly behavior affects quite a few prpls.
It's mostly a question of whether the defer point is always reached reliably - would, say, a newly created channel with no other members skip the add users call? Some weird prpl that just don't do it, and add them with delay?
| @@ -1154,6 +1184,10 @@ void prplcb_conv_add_users(PurpleConversation *conv, GList *cbuddies, gboolean n | |||
|
|
|||
| imcb_chat_add_buddy(gc, pcb->name); | |||
| } | |||
| purple_hint_chat_names(gc, conv); | |||
| if (!gc->joined) { | |||
There was a problem hiding this comment.
Note to self, recheck the meaning of this one.
dequis
reviewed
Apr 4, 2019
|
Is the use_matrix_alias for using something similar to the telegram username? |
|
No, use_matrix_alias is a sort-of hack that works only for the Matrix prpl,
unfortunately.On Sat, 2019-06-15 at 08:50 -0700, Thaodan wrote:
… Is the use_matrix_alias for using something similar to the telegram username?
If yes it could have some use in telegram too.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.
[
{
***@***.***": "http://schema.org",
***@***.***": "EmailMessage",
"potentialAction": {
***@***.***": "ViewAction",
"target": "
#125?email_source=notifications\u0026email_token=ACHXT5TFLZTOIVMSUQ6IZMTP2UFSVA5CNFSM4HDSDB6KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXY2XDQ#issuecomment-502377358
",
"url": "
#125?email_source=notifications\u0026email_token=ACHXT5TFLZTOIVMSUQ6IZMTP2UFSVA5CNFSM4HDSDB6KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXY2XDQ#issuecomment-502377358
",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
***@***.***": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]
|
|
What's missing in this to be merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Most of these changes are aimed at making matrix not a pain to use)
defer_joinsoption on prpl accounts waits for users to be addedto a prpl conversation before adding the bitlbee user, in the hope
of being able to get some chat name/alias metadata before doing so.
added.)
name_with_tagoptions prefixes the account tag to the name hintfor prpl accounts, in order to namespace prpl channels somewhat.
use_matrix_aliasoption is specialized for the purple-matrixplugin, and makes the name hint use the
matrix_aliasdata itemof the prpl conversation, instead of the title.
MAX_NICK_LENGTHwas increased to 80 (because matrix room names are long).