purple: add option to automatically mark new messages as read #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(Most of these changes are aimed at making matrix not a pain to use) - The `defer_joins` option on prpl accounts waits for users to be added to a prpl conversation before adding the bitlbee user, in the hope of being able to get some chat name/alias metadata before doing so. - (To that end, the name hint for rooms is now updated when users are added.) - The `name_with_tag` options prefixes the account tag to the name hint for prpl accounts, in order to namespace prpl channels somewhat. - The `use_matrix_alias` option is specialized for the purple-matrix plugin, and makes the name hint use the `matrix_alias` data item of the prpl conversation, instead of the title.
- The new `mark_read` option controls whether messages are marked as read upon reception by bitlbee. - Not all libpurple prpls actually support this, but the ones that do (e.g. slack-libpurple) seem to be watching out for a conversation update of type PURPLE_CONV_UPDATE_UNSEEN, so we send that on message reception if the option is enabled. - Additionally, some (like purple-facebook) check for has_focus, so we always return TRUE for that if mark_read is enabled.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(depends on #125)
mark_readoption controls whether messages are markedas read upon reception by bitlbee.
do (e.g. slack-libpurple) seem to be watching out for a
conversation update of type PURPLE_CONV_UPDATE_UNSEEN, so we
send that on message reception if the option is enabled.
we always return TRUE for that if mark_read is enabled.