Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DO NOT MERGE] cmake: Migrate CI scripts to CMake-based build system -- WIP #29790

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from
Draft

[DO NOT MERGE] cmake: Migrate CI scripts to CMake-based build system -- WIP #29790

wants to merge 5 commits into from

Conversation

hebasto
Copy link
Member

@hebasto hebasto commented Apr 2, 2024

This PR goal is to facilitate testing CI scripts migration to the CMake.

@DrahtBot
Copy link
Contributor

DrahtBot commented Apr 2, 2024 •
edited

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Code Coverage

For detailed information about the code coverage, see the test coverage report.

Reviews

See the guideline for information on the review process.
A summary of reviews will appear here.

Conflicts

Reviewers, this pull request conflicts with the following ones:

  • #bitcoin-core/gui/777 (getrawtransaction implementation by BrandonOdiwuor)
  • #bitcoin-core/gui/733 (Deniability - a tool to automatically improve coin ownership privacy by denavila)
  • #30112 (rpc: introduce getversion RPC by 0xB10C)
  • #30049 (build, test, doc: Temporarily remove Android-related stuff by hebasto)
  • #30043 (net: Replace libnatpmp with built-in PCP+NATPMP implementation by laanwj)
  • #29881 (guix: use GCC 13 to builds releases by fanquake)
  • #29868 (Reintroduce external signer support for Windows by hebasto)
  • #29852 ([WIP] build: remove need to test for endianness by fanquake)
  • #29835 ([WIP] libevent @ master + use CMake by fanquake)
  • #29723 (depends: build zeromq with CMake by fanquake)
  • #26950 (cleanse: switch to SecureZeroMemory for Windows cross-compile, check for usage by fanquake)
  • #25573 ([POC] guix: produce a fully -static-pie bitcoind by fanquake)
  • #21590 (Safegcd-based modular inverses in MuHash3072 by sipa)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

@hebasto hebasto force-pushed the 240402-cmake-DA branch 2 times, most recently from 2fa6fe0 to c26bd2a Compare April 2, 2024 16:04
@DrahtBot
Copy link
Contributor

DrahtBot commented Apr 2, 2024

🚧 At least one of the CI tasks failed. Make sure to run all tests locally, according to the
documentation.

Possibly this is due to a silent merge conflict (the changes in this pull request being
incompatible with the current code in the target branch). If so, make sure to rebase on the latest
commit of the target branch.

Leave a comment here, if you need help tracking down a confusing failure.

Debug: https://github.com/bitcoin/bitcoin/runs/23353954951

This was referenced Apr 3, 2024
Closed
Merged
Merged
Draft
Draft
Draft
Merged
Draft
Open
@hebasto hebasto force-pushed the 240402-cmake-DA branch 2 times, most recently from b24c0aa to c393fa4 Compare April 3, 2024 11:30
@hebasto hebasto mentioned this pull request Apr 3, 2024
Merged
This was referenced Apr 4, 2024
Merged
Merged
@DrahtBot DrahtBot mentioned this pull request Apr 5, 2024
Merged
@hebasto hebasto mentioned this pull request Apr 5, 2024
Merged
@hebasto
Copy link
Member Author

hebasto commented May 21, 2024

@maflcko

The last two commits in this branch have been cherry-picked into hebasto#177.

Would you mind leave your comment in there please?

@hebasto hebasto force-pushed the 240402-cmake-DA branch 2 times, most recently from bca48b1 to fabf0ba Compare May 21, 2024 14:10
@DrahtBot
Copy link
Contributor

🚧 At least one of the CI tasks failed. Make sure to run all tests locally, according to the
documentation.

Possibly this is due to a silent merge conflict (the changes in this pull request being
incompatible with the current code in the target branch). If so, make sure to rebase on the latest
commit of the target branch.

Leave a comment here, if you need help tracking down a confusing failure.

Debug: https://github.com/bitcoin/bitcoin/runs/25229150795

This was referenced May 21, 2024
Merged
Merged
@hebasto
Copy link
Member Author

hebasto commented May 22, 2024

I've noticed two issues in the "tidy" job so far:

  1. Cannot open mapping file '/ci_container_base/ci/scratch/build-/contrib/devtools/iwyu/bitcoin.core.imp': No such file or directory.

  2. Missed disabling EXPORT_COMPILE_COMMANDS property for targets in the crc32c subtree.

The recent push includes:

hebasto added a commit to hebasto/bitcoin that referenced this pull request May 23, 2024
@hebasto
Merge #206: cmake: Disable EXPORT_COMPILE_COMMANDS for all subtree …
6c2be70 
…targets

a37b0df fixup! cmake: Build `secp256k1` static library (Hennadii Stepanov)
4883df5 fixup! cmake: Build `crc32c` static library (Hennadii Stepanov)

Pull request description:

  Fixes the second point from bitcoin#29790 (comment):
  >    2. Missed disabling `EXPORT_COMPILE_COMMANDS` property for targets in the `crc32c` subtree.

Top commit has no ACKs.

Tree-SHA512: 231cda1190faab44f0b0ec72de1ed4abd0f490026c781b26d9ea374995db0d5d00d575c23e8775057a1c59ee1fbf7dcb0b58109ead3051c1ee23e243d852524d
@hebasto
Copy link
Member Author

hebasto commented May 23, 2024

I've noticed two issues in the "tidy" job so far:

  1. Cannot open mapping file '/ci_container_base/ci/scratch/build-/contrib/devtools/iwyu/bitcoin.core.imp': No such file or directory.

The recent push includes commits from hebasto#205, which fixes the point 1.

  1. Missed disabling EXPORT_COMPILE_COMMANDS property for targets in the crc32c subtree.

The point 2 has been fixed already.

@DrahtBot
Copy link
Contributor

🚧 At least one of the CI tasks failed. Make sure to run all tests locally, according to the
documentation.

Possibly this is due to a silent merge conflict (the changes in this pull request being
incompatible with the current code in the target branch). If so, make sure to rebase on the latest
commit of the target branch.

Leave a comment here, if you need help tracking down a confusing failure.

Debug: https://github.com/bitcoin/bitcoin/runs/25322968099

hebasto added a commit to hebasto/bitcoin that referenced this pull request May 23, 2024
@hebasto
Merge #205: cmake: Fix "tidy" CI job
f5f951d 
de15de4 fixup! ci: Migrate CI scripts to CMake (Hennadii Stepanov)
e59e96d fixup! ci: Migrate CI scripts to CMake (Hennadii Stepanov)

Pull request description:

  Fixes the first point from bitcoin#29790 (comment):
  >    1. `Cannot open mapping file '/ci_container_base/ci/scratch/build-/contrib/devtools/iwyu/bitcoin.core.imp': No such file or directory.`

Top commit has no ACKs.

Tree-SHA512: ebead6da2729620237703d05b6cbf9b5ad73f139a9020f3785f0c9e89054fbaddd4c5ae687278042c6b467359a2e0e641f09d5f3d5c37429a558f508832c6f2d
@DrahtBot DrahtBot mentioned this pull request May 23, 2024
Open
This was referenced May 23, 2024
Open
Open
Draft
Draft
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fanquake fanquake fanquake left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@hebasto @DrahtBot @maflcko @theuni @fanquake