-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Time independet ema for path planning smoothing #444
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Flova
requested review from
jaagut,
SammyRamone,
timonegk,
jgueldenstein and
texhnolyze
May 6, 2024 19:49
SammyRamone
approved these changes
May 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
We did some parameter tuning, but further testing is required |
jaagut
reviewed
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Currently, the path planning exponential smoothing is dependent on the update frequency of the path planning. But this can be formulated in a time independent discrete way by using the time constant tau (see https://en.wikipedia.org/wiki/Exponential_smoothing#Time_constant). It described the amount of time a unit impulse takes to decay to 1 - 1/e which is roughly 63%. Using this, we can calculate a smoothing factor alpha for arbitrary time deltas instead of using a fixed one. This accounts for changed rates as well as fluctuations in the timers rate.
Here you can see two impulse responses with different discretization, but same tau (= 0.39):
Note: k and alpha are used as synonyms here for legacy reasons.
Proposed changes
Checklist
colcon build
Idea: We can add this also to the IMU filter!