Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no cheering after goal by goalie #403

Merged
merged 3 commits into from
May 17, 2024

Conversation

ayin21
Copy link
Contributor

@ayin21 ayin21 commented Apr 18, 2024

Summary

Adds a new decision to the mail dsd, that checks if the robot is in a given percentage of the length of the field. The decision is used in the main dsd to make sure, that the goalie only plays the cheering animation when he is in his own half of the field. In the case that he made the goal the cheering animation would take time that he needs to get in his own half.

Proposed changes

Related issues

Checklist

  • Run colcon build
  • Write documentation
  • Test on your machine
  • Test on the robot
  • Create issues for future work
  • Triage this PR and label it

@ayin21 ayin21 marked this pull request as ready for review April 30, 2024 15:57
@ayin21 ayin21 requested review from Flova and jaagut April 30, 2024 15:57
@jaagut jaagut merged commit ea18fa6 into main May 17, 2024
2 checks passed
@jaagut jaagut deleted the no-cheering-after-goalie-made-goal-himself branch May 17, 2024 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants