Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Tab bug in chinese language #362

Merged
merged 1 commit into from May 14, 2024
Merged

Conversation

curder
Copy link
Contributor

@curder curder commented Apr 8, 2024

Fixed Tab bug in Chinese language. #357

Copy link

what-the-diff bot commented Apr 8, 2024

PR Summary

  • Enhanced Role Resource Component
    • Added identifiable labels to different tabs within the 'RoleResource.php' file. These labels improve the usability and understanding of the user interface for application components. Each label is specifically tied to a named key. Here are the changes:
      1. Added 'filament-shield::filament-shield.resources' label to the tab with key 'resources'.
      2. Added 'filament-shield::filament-shield.pages' label to the tab with key 'pages'.
      3. Added 'filament-shield::filament-shield.widgets' label to the tab with key 'widgets'.
      4. Added 'filament-shield::filament-shield.custom' label to the tab with key 'custom'.

@curder curder changed the title Tab bug in other languages (chinese and khmer) Fixed Tab bug in chinese language Apr 8, 2024
@valpuia604
Copy link

valpuia604 commented Apr 9, 2024

Oh, this is the fix... 🤣 I try to create a fix but I cannot figure out. this is the easy one.

Checked and working perfect. thanks for this PR

@bezhanSalleh bezhanSalleh merged commit ca21a5e into bezhanSalleh:3.x May 14, 2024
1 check passed
@bezhanSalleh
Copy link
Owner

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants