Fix Ci failing over dead code in tests

[Brezak]

Objective

Fix Pr CI failing over dead code in tests and main branch CI failing over a missing semicolon. Fixes #12620.

Solution

Add dead_code annotations and a semicolon.

[Brezak]

Now we wait and see if that was all the dead code the compiler recognizes.

[Brezak]

Should work now. I'll investigate a better solution when CI works again.

[alice-i-cecile]

Looks like we need to bless the new output of the compile-fail tests too.

[alice-i-cecile]

Another compile-fail failure in https://github.com/bevyengine/bevy/actions/runs/8378534423/job/22943464592?pr=12623#step:6:261.

I've opened #12627 to see how we can make this less brittle.

[Brezak]

Either I'm doing something wrong or the errors rustc emits look different between Windows and Linux. Blessing the tests locally keeps failing so I've resorted to just copy pasting the expected output from the CI log.

[Brezak]

If this works now then the issue was that I forgot to add a newline to the end of the missing_deref.fail.stderr file when copying the CI output.

[Brezak]

It works!!!. I'm sorry it took so long.

[alice-i-cecile]

It works!!!. I'm sorry it took so long.

No, this was very speedy! Much appreciated: it's a real chore to fix these failures and I love it when contributors tackle them.

[mockersf]

Either I'm doing something wrong or the errors rustc emits look different between Windows and Linux. Blessing the tests locally keeps failing so I've resorted to just copy pasting the expected output from the CI log.

Yup it's #8962, somehow the output differs depending on your OS...