Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI: allow border radius to be optional for images and background #12592

Merged
merged 1 commit into from Mar 20, 2024
Merged

UI: allow border radius to be optional for images and background #12592

merged 1 commit into from Mar 20, 2024

Conversation

mockersf
Copy link
Member

@mockersf mockersf commented Mar 20, 2024 •
edited

Objective

Solution

  • Makes the component BorderRadius optional in the query, as it's not always present. Use [0.; 4] as border radius in the extracted node when none was found

@mockersf mockersf added C-Bug An unexpected or incorrect behavior A-UI Graphical user interfaces, styles, layouts, and widgets labels Mar 20, 2024
@mockersf mockersf added this to the 0.14 milestone Mar 20, 2024
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Mar 20, 2024
@alice-i-cecile alice-i-cecile added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Mar 20, 2024
Merged via the queue into bevyengine:main with commit 779e4c4 Mar 20, 2024
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

@pablo-lua pablo-lua pablo-lua approved these changes

Assignees
No one assigned
Labels
A-UI Graphical user interfaces, styles, layouts, and widgets C-Bug An unexpected or incorrect behavior S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
0.14
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mockersf @alice-i-cecile @pablo-lua