Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

check that patches are not broken #12457

Merged
merged 2 commits into from Mar 17, 2024
Merged

check that patches are not broken #12457

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
39bdf99
patch and build
mockersf Mar 13, 2024
17f371b
typo
mockersf Mar 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
28 changes: 28 additions & 0 deletions .github/workflows/validation-jobs.yml
View file
Open in desktop
Expand Up @@ -286,3 +286,31 @@ jobs:
run: sudo apt-get update; sudo apt-get install --no-install-recommends libasound2-dev libudev-dev
- name: Run cargo udeps
run: cargo udeps

check-example-showcase-patches-still-work:
if: ${{ github.event_name == 'merge_group' }}
runs-on: ubuntu-latest
timeout-minutes: 30
steps:
- uses: actions/checkout@v4
- uses: actions/cache@v4
with:
path: |
~/.cargo/bin/
~/.cargo/registry/index/
~/.cargo/registry/cache/
~/.cargo/git/db/
target/
key: ${{ runner.os }}-cargo-check-showcase-patches-${{ hashFiles('**/Cargo.toml') }}
- uses: dtolnay/rust-toolchain@stable
- name: Installs cargo-udeps
run: cargo install --force cargo-udeps
Comment on lines +306 to +307
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know I'm a bit late, but does this need to install cargo-udeps if we're just calling cargo build? Was this leftover from a copy-paste?

- name: Install alsa and udev
run: sudo apt-get update; sudo apt-get install --no-install-recommends libasound2-dev libudev-dev
- name: Apply patches
run: |
for patch in tools/example-showcase/*.patch; do
git apply --ignore-whitespace $patch
done
- name: Build with patches
run: cargo build